-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rdkafka input plugin #350
Comments
It depends on rdkafka-ruby. When rdkafka-ruby merge above patch and release new version, we can test it. |
Hi @repeatedly, may I ask what causes the hard dependency on the above PR? I think a similar batching method could be fairly easily implemented in this client lib with the existing functionality exposed by rdkafka-ruby, that could be replaced in the future once the feature is merged. |
I'm not familiar with entire rdkafka's API, so I can't judge above unfinished implementation is good or not. |
Hence solving for fluent#350
Hence solving for fluent#350 Signed-off-by: Tamas Kornai <[email protected]>
I smoke tested the above PR locally, but it is definitely not battle hardened yet. |
I have created a new PR which helps with tracking the changes against the in_kafka_group.rb implementation: |
This issue has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 30 days |
released as fluent-plugin-kafka v0.15.0 |
rdkafka-ruby is now considering
each_batch
support.karafka/rdkafka-ruby#124
We can implement
in_rdkafka
with this feature.The text was updated successfully, but these errors were encountered: