Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdkafka input plugin #350

Closed
repeatedly opened this issue Jul 13, 2020 · 7 comments
Closed

rdkafka input plugin #350

repeatedly opened this issue Jul 13, 2020 · 7 comments

Comments

@repeatedly
Copy link
Member

rdkafka-ruby is now considering each_batch support.

karafka/rdkafka-ruby#124

We can implement in_rdkafka with this feature.

@repeatedly
Copy link
Member Author

may I ask that when can be release?

It depends on rdkafka-ruby. When rdkafka-ruby merge above patch and release new version, we can test it.

@tkornai
Copy link
Contributor

tkornai commented Sep 5, 2020

Hi @repeatedly,

may I ask what causes the hard dependency on the above PR? I think a similar batching method could be fairly easily implemented in this client lib with the existing functionality exposed by rdkafka-ruby, that could be replaced in the future once the feature is merged.

@repeatedly
Copy link
Member Author

I'm not familiar with entire rdkafka's API, so I can't judge above unfinished implementation is good or not.
If you ok with current implemenation, could you send a patch?

tkornai added a commit to tkornai/fluent-plugin-kafka that referenced this issue Sep 7, 2020
tkornai added a commit to tkornai/fluent-plugin-kafka that referenced this issue Sep 7, 2020
Hence solving for fluent#350

Signed-off-by: Tamas Kornai <[email protected]>
@tkornai
Copy link
Contributor

tkornai commented Sep 7, 2020

I smoke tested the above PR locally, but it is definitely not battle hardened yet.

@tkornai
Copy link
Contributor

tkornai commented Sep 8, 2020

I have created a new PR which helps with tracking the changes against the in_kafka_group.rb implementation:
#367

@github-actions
Copy link

github-actions bot commented Jul 6, 2021

This issue has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 30 days

@github-actions github-actions bot added the stale label Jul 6, 2021
@kenhys
Copy link
Contributor

kenhys commented Jul 26, 2021

released as fluent-plugin-kafka v0.15.0

@kenhys kenhys closed this as completed Jul 26, 2021
@ashie ashie removed the stale label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants