Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msi: apply new package name to default config #527

Merged
merged 1 commit into from
Jul 18, 2023
Merged

msi: apply new package name to default config #527

merged 1 commit into from
Jul 18, 2023

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Jul 18, 2023

No description provided.

@daipom
Copy link
Contributor Author

daipom commented Jul 18, 2023

There is no longer any reason to leave these paths as before, right?

@daipom daipom mentioned this pull request Jul 18, 2023
Merged
kenhys
kenhys approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daipom
Copy link
Contributor Author

daipom commented Jul 18, 2023

Thanks for your review!

@daipom daipom merged commit 35aebdc into fluent:master Jul 18, 2023
@daipom daipom deleted the msi-apply-new-package-name-to-default-config branch July 18, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenhys kenhys kenhys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daipom @kenhys