-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop maintaining multiple copies of the same conf #525
Stop maintaining multiple copies of the same conf #525
Conversation
Just refactoring. This does not change the result. Signed-off-by: Daijiro Fukuda <[email protected]>
We need to do some fixes following this.
I have one question. It is not used after the following PR: but it is still better to have the default config under the |
I think so. |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the rest of the work will be done in another PR (#525 (comment)),
it seems a reasonable fix.
Thanks for your review! |
Done all TODO! |
Just refactoring. This does not change the result.