Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the time for waiting dummy fluentd processes to fix the tests #58

Merged
merged 2 commits into from
Jan 16, 2017
Merged

Increase the time for waiting dummy fluentd processes to fix the tests #58

merged 2 commits into from
Jan 16, 2017

Conversation

saidie
Copy link
Contributor

@saidie saidie commented Nov 16, 2016

Tests are failed due to recent fluentd updates (ref: #57 (comment)).
This could be fixed by increasing the wait time of DummyFluentd.

@saidie
Copy link
Contributor Author

saidie commented Nov 16, 2016

socketry/cool.io#50 ?

Add wait to some test cases
4267cc7 
It ensures that the dummy fluentd accpeted the connection
@saidie
Copy link
Contributor Author

saidie commented Nov 16, 2016 •
edited
Loading

It seems that DummyFluentd#shutdown is called (and remote TCP socket watcher is detached from the event loop) before the connect() is accepted (and watched; here).

Above commit inserts fluentd.wait_transfer to test cases which a logger only do connect().

@repeatedly repeatedly merged commit d43bb3e into fluent:master Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saidie @repeatedly