-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement standard compatible severity formatting to LevelFluentLogger #57
Implement standard compatible severity formatting to LevelFluentLogger #57
Conversation
LevelFluentLogger
LGTM. @toyama0919 ping? |
Thank you! |
It seems to fail due to recent master branch updates of https://github.com/fluent/fluentd |
😊 LGTM. |
Thank you for LGTM 😊 |
By manual binary search, I found that the test failure is caused by this fluentd PR. |
That's weird. It means the response time of new in_forward is longer than old in_forward? |
I'm not well understood the detail of the fluentd PR but it sounds weird too that new plugin is slower. |
If increasing wait time resolves test failures, |
By my investigation, the problem is that the posted content has not yet been read by in_forward plugin when |
Sorry for the late. Just merged. |
Hi,
The recently added standard logger compatible
LevelFluentLogger
is great!I've been tried to use it in my project and noticed that its use of formatter is incompatible with standard one.
That is,
format_severity
, which is a private method of::Logger
, is used inside the formatter here. This could be simply becauseformat_severity
is not applied here.In the standard
::Logger
implementation,format_severity
is applied before passing a severity to formatter like this.This PR implements standard log formatter compatible way of severity formatting.