input_chunk: handle filter_do edge case #8229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonk
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
Contributor
Author
|
I tried to add a test for this similar to my last PR, but unfortunately the test's mechanism for reading total records doesn't have enough granularity to get exact record counts and make sure that it's a precise expected number. |
flb_filter_do may modify the input chunk's total records, meaning that if there is a filter in the pipeline the total records could be double-counted which breaks anything that relies on and event chunk's `total_records`. Signed-off-by: braydonk <braydonk@google.com>
braydonk
force-pushed
the
update_record_total_with_filter
branch
from
96cc568 to
37cb10d
Compare
Clarify comment to demonstrate that flb_filter_do actually overwrites the value not just changing it. Signed-off-by: braydonk <braydonk@google.com>
Contributor
Author
|
macos unit test failures are flakes. |
Contributor
Author
|
@leonardo-albertovich bumping this, fixes an edge case I missed in the last PR. |
9 tasks
Contributor
Author
|
@edsiper @leonardo-albertovich any chance of getting some eyes on this? |
This was referenced Dec 15, 2023
9 tasks
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flb_filter_domay modify the input chunk's total records, meaning that if there is a filter in the pipeline the total records could be double-counted which breaks anything that relies on an event chunk'stotal_records.Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.