in_winevtlog: pass correct value #8179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: braydonk <braydonk@google.com>
braydonk
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
cosmo0920
approved these changes
Nov 15, 2023
Contributor
cosmo0920
left a comment
cosmo0920
left a comment
There was a problem hiding this comment.
Good catch! I've overlooked this. Thanks for your careful work. 😄
9 tasks
franciscovalentecastro
pushed a commit
to franciscovalentecastro/fluent-bit
that referenced
this pull request
Nov 27, 2023
Signed-off-by: braydonk <braydonk@google.com>
braydonk
added a commit
to braydonk/fluent-bit
that referenced
this pull request
Nov 28, 2023
Signed-off-by: braydonk <braydonk@google.com>
avilevy18
pushed a commit
to avilevy18/fluent-bit
that referenced
this pull request
Nov 29, 2023
Signed-off-by: braydonk <braydonk@google.com> (cherry picked from commit 5626757)
igorpeshansky
pushed a commit
to igorpeshansky/fluent-bit
that referenced
this pull request
Nov 29, 2023
Signed-off-by: braydonk <braydonk@google.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function needs the
winevtlog_config*not the log encoder. This was causing a crash on any event log with<Binary \>in it.#7832