filter_log_to_metrics: Fix config key after rename#7967
Closed
wndhydrnt wants to merge 1 commit intofluent:masterfrom
Closed
filter_log_to_metrics: Fix config key after rename#7967wndhydrnt wants to merge 1 commit intofluent:masterfrom
wndhydrnt wants to merge 1 commit intofluent:masterfrom
Conversation
e784379 to
0fdc7d0
Compare
Contributor
Author
|
Configuration: |
This was referenced Sep 24, 2023
cosmo0920
approved these changes
Sep 25, 2023
Contributor
|
It seems like I merged part of your change in #7972. Mind rebasing off of master so we can get the fixed log error message? |
Signed-off-by: Markus Meyer <hydrantanderwand@gmail.com>
0fdc7d0 to
2b6d525
Compare
Contributor
Author
|
Thanks for the hint @pwhelan. Now this PR contains a change to a log message only. @cosmo0920 Feel free tom erge or close this MR as you see fit. |
cosmo0920
approved these changes
Sep 27, 2023
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
Author
|
Closing due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #7739 was merged, the config key
labelwas renamed toadd_labelin #7964.Not all occurrences of the key
labelwere renamed in #7964, which leads to a regression and failing tests.This change renames the key throughout the code of the filter.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.