Skip to content

filter_log_to_metrics: Add documentation for add_label#1167

Merged
lecaros merged 3 commits intofluent:masterfrom
wndhydrnt:filter-log-to-metrics-label-key
Oct 26, 2023
Merged

filter_log_to_metrics: Add documentation for add_label#1167
lecaros merged 3 commits intofluent:masterfrom
wndhydrnt:filter-log-to-metrics-label-key

Conversation

@wndhydrnt
Copy link
Contributor

@wndhydrnt wndhydrnt commented Jul 23, 2023

Signed-off-by: Markus Meyer <hydrantanderwand@gmail.com>
@wndhydrnt wndhydrnt changed the title filter_log_to_metrics: Add documentation for label filter_log_to_metrics: Add documentation for add_label Sep 24, 2023
@lecaros lecaros added waiting-for-user Waiting for user/contributors feedback or requested changes dco DCO failing labels Sep 24, 2023
@cosmo0920
Copy link
Contributor

Could you resolve DCO error on the commit 8074ff6?

Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding add_label parameter looks great. I found an invalid JSON parameter. Could you take a look then?

Signed-off-by: Markus Meyer <hydrantanderwand@gmail.com>
Signed-off-by: Markus Meyer <hydrantanderwand@gmail.com>
@wndhydrnt wndhydrnt force-pushed the filter-log-to-metrics-label-key branch from 8074ff6 to 9552e6a Compare September 25, 2023 15:33
@wndhydrnt wndhydrnt requested a review from cosmo0920 September 25, 2023 15:35
@wndhydrnt
Copy link
Contributor Author

Hello @cosmo0920 @lecaros

Fluent Bit 2.10.0, which contains the add_label feature, has been released a few weeks ago already. This PR is still open so people have no way to discover through the documentation that the feature exists.

What is needed to get this PR merged?

@lecaros
Copy link
Contributor

lecaros commented Oct 26, 2023

Hi @wndhydrnt,
Are we okay to include this doc without having fluent/fluent-bit#7967 merged yet?

edit: Just reviewed it, and I think we're ok. I'll merge it.

@lecaros lecaros merged commit d86e084 into fluent:master Oct 26, 2023
TomlinfreeGit pushed a commit to TomlinfreeGit/fluent-bit-docs that referenced this pull request Oct 28, 2025
* filter_log_to_metrics: Add documentation for label

Signed-off-by: Markus Meyer <hydrantanderwand@gmail.com>

* update after renaming key "label" to "add_label"

Signed-off-by: Markus Meyer <hydrantanderwand@gmail.com>

* fix invalid json

Signed-off-by: Markus Meyer <hydrantanderwand@gmail.com>

---------

Signed-off-by: Markus Meyer <hydrantanderwand@gmail.com>
Signed-off-by: Tom <yao.lin@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco DCO failing waiting-for-user Waiting for user/contributors feedback or requested changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants