Skip to content

tests: runtime: Mark another port 4318 raced test case - #11627

Merged
edsiper merged 1 commit into
masterfrom
cosmo0920-add-port-4318-raced-test-case
Mar 30, 2026
Merged

tests: runtime: Mark another port 4318 raced test case#11627
edsiper merged 1 commit into
masterfrom
cosmo0920-add-port-4318-raced-test-case

Conversation

@cosmo0920

@cosmo0920 cosmo0920 commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

cumulative_to_delta case also uses port 4318.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Tests
    • Updated test infrastructure to extend runtime test coverage for processor components.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@coderabbitai

coderabbitai Bot commented Mar 29, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2c108fa7-e99e-440f-a421-3b3f05e823a9

📥 Commits

Reviewing files that changed from the base of the PR and between 32a3cbb and e1768f6.

📒 Files selected for processing (1)
  • tests/runtime/CMakeLists.txt

📝 Walkthrough

Walkthrough

This PR updates the CMake test configuration to add the flb-rt-processor_cumulative_to_delta runtime test executable to the serialized test set locked to port 4318, extending resource locking coverage for tests requiring exclusive port access.

Changes

Cohort / File(s) Summary
CMake Test Configuration
tests/runtime/CMakeLists.txt
Added flb-rt-processor_cumulative_to_delta test executable to the runtime-port-4318 resource-locked test group to ensure serialized execution on port 4318.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • edsiper

Poem

🐰 A test joins the queue, locked tight with care,
Port 4318, no conflicts to share,
One line departed, two lines appear,
Cumulative delta, serialized here! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: marking another test case that races on port 4318, which directly aligns with the pull request's objective of addressing port 4318 race conditions in runtime tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cosmo0920-add-port-4318-raced-test-case

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@edsiper
edsiper merged commit 055b0cc into master Mar 30, 2026
36 of 38 checks passed
@edsiper
edsiper deleted the cosmo0920-add-port-4318-raced-test-case branch March 30, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants