Sync: TestPR: remove me #90
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the $PATH from the runtime config, if it includes one, so that when the command to run isn't an absolute path and the command isn't being processed by the shell, exec.Command()'s internal call to exec.LookPath() will find it. Signed-off-by: Nalin Dahyabhai <[email protected]>
Update the version of Go we suggest in go.mod to 1.24, and update the one we use for the vendoring CI test to match. Signed-off-by: Nalin Dahyabhai <[email protected]>
Use the CutPrefix(), SplitSeq(), and FieldsSeq() functions from the strings package when chopping up or iterating over parts of strings, per golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize Signed-off-by: Nalin Dahyabhai <[email protected]>
Use maps.Copy() instead of iterating over a map's keys and values to copy the keys and values to a new map. Overdue from golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize Signed-off-by: Nalin Dahyabhai <[email protected]>
Drop the "omitempty" tag from the "json" tag on struct members that are themselves structs, since the JSON encoder doesn't actually do that, per golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize Signed-off-by: Nalin Dahyabhai <[email protected]>
Yes, this helper function always returns nil as one of its results, but that lets the callers not have to remember to do that, so it's shorter than changing the call sites. Signed-off-by: Nalin Dahyabhai <[email protected]>
Signed-off-by: Nalin Dahyabhai <[email protected]>
When checking that certain directories are masked, treat the readable-but-empty case as acceptable, as before, and now also accept actually-unreadable case, which can happen with crun 1.24. Signed-off-by: Nalin Dahyabhai <[email protected]>
chroot: use $PATH when finding commands
Update to Go 1.24
Relax the permissions on directories we create to hold mount targets, from 0700 to 0755. Signed-off-by: Nalin Dahyabhai <[email protected]>
When checking that certain directories are masked, treat the readable-but-empty case as acceptable, as before, and now also accept the actually-unreadable case, which can happen with crun 1.24. Signed-off-by: Nalin Dahyabhai <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…m-spf13-pflag-1.x fix(deps): update module github.com/spf13/pflag to v1.0.10
…m-fsouza-go-dockerclient-1.x fix(deps): update module github.com/fsouza/go-dockerclient to v1.12.2
…m-opencontainers-runc-1.x fix(deps): update module github.com/opencontainers/runc to v1.3.1
…g-x-sync-0.x fix(deps): update module golang.org/x/sync to v0.17.0
…ible Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…m-opencontainers-cgroups-0.x fix(deps): update module github.com/opencontainers/cgroups to v0.0.5
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…m-moby-buildkit-0.x fix(deps): update module github.com/moby/buildkit to v0.24.0
Run: create parent directories of mount targets with mode 0755
…g-x-crypto-0.x fix(deps): update module golang.org/x/crypto to v0.42.0
…m-docker-docker-28.x fix(deps): update module github.com/docker/docker to v28.4.0+incompatible
Signed-off-by: flouthoc <[email protected]>
Fixes issue caught in containers#6385 Signed-off-by: flouthoc <[email protected]>
.cirrus.yml: Test Vendoring bump golang
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…m-cyphar-filepath-securejoin-0.x fix(deps): update module github.com/cyphar/filepath-securejoin to v0.5.0
flouthoc
force-pushed
the
sync/container-libs-3
branch
from
aa8d5a1 to
7c609e1
Compare
flouthoc
force-pushed
the
sync/container-libs-3
branch
from
7c609e1 to
ab75e9e
Compare
|
A friendly reminder that this PR had no activity for 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automatically vendors changes from repo-A#3.