Update to Go 1.24 #6380
Merged
Update to Go 1.24 #6380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the version of Go we suggest in go.mod to 1.24, and update the one we use for the vendoring CI test to match. Signed-off-by: Nalin Dahyabhai <[email protected]>
Use the CutPrefix(), SplitSeq(), and FieldsSeq() functions from the strings package when chopping up or iterating over parts of strings, per golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize Signed-off-by: Nalin Dahyabhai <[email protected]>
Use maps.Copy() instead of iterating over a map's keys and values to copy the keys and values to a new map. Overdue from golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize Signed-off-by: Nalin Dahyabhai <[email protected]>
Drop the "omitempty" tag from the "json" tag on struct members that are themselves structs, since the JSON encoder doesn't actually do that, per golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize Signed-off-by: Nalin Dahyabhai <[email protected]>
Yes, this helper function always returns nil as one of its results, but that lets the callers not have to remember to do that, so it's shorter than changing the call sites. Signed-off-by: Nalin Dahyabhai <[email protected]>
Signed-off-by: Nalin Dahyabhai <[email protected]>
When checking that certain directories are masked, treat the readable-but-empty case as acceptable, as before, and now also accept actually-unreadable case, which can happen with crun 1.24. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
commented
Sep 10, 2025
| run_buildah run $cid ls $mask | ||
| expect_output "" "Directories should be empty" | ||
| run_buildah run $cid sh -c "echo $mask/*" # globbing will fail whether it's simply unreadable, or readable but empty | ||
| expect_output "$mask/*" "Directories should be empty" |
There was a problem hiding this comment.
I'll fix this spaces-and-tabs mess if this PR needs to be revised.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@flouthoc PTAL |
|
LGTM |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
Update to require Go 1.24, at minimum, now that Go 1.25 is out and 1.23 is no longer supported. Run the "modernize" tool to adopt some newer APIs.
How to verify it
The usual battery of tests.
Which issue(s) this PR fixes:
This should unblock a number of dependency update PRs.
Special notes for your reviewer:
Does this PR introduce a user-facing change?