Skip to content

fix: ignore more in watcher#2168

Merged
JoshuaKGoldberg merged 1 commit intomainfrom
watcher-ignores
Jan 29, 2026
Merged

fix: ignore more in watcher#2168
JoshuaKGoldberg merged 1 commit intomainfrom
watcher-ignores

Conversation

@lishaduck
Copy link
Copy Markdown
Member

@lishaduck lishaduck commented Jan 27, 2026 •
edited
Loading

PR Checklist

Overview

It does annoy me that this is effectively a duplicate of

flint/packages/core/src/host/createDiskBackedLinterHost.ts

Line 12 in abc2bb9

const ignoredPaths = ["/node_modules", "/.git", "/.jj"];
. Speaking of which, we should probably make this customizable like Vite at some point.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 27, 2026

⚠️ No Changeset found

Latest commit: 6f064f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 27, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
flint Ready Ready Preview, Comment Jan 27, 2026 6:54pm

Request Review

lishaduck
lishaduck commented Jan 27, 2026
View reviewed changes
packages/cli/src/runCliWatch.ts
if (fileName.startsWith("node_modules/.cache")) {
if (
fileName.startsWith("node_modules/.cache") ||
fileName.startsWith(".git") ||
Copy link
Copy Markdown
Member Author

@lishaduck lishaduck Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.git/fsmonitor--deamon/cookies/ is the reason I sent this in, but I also use watchman with jj so that'd be an issue if/when I adopt Flint IRL.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on the followups too 🙂

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval One team member approved; we're now waiting for a second approval or for 2 business days to pass. label Jan 28, 2026
@JoshuaKGoldberg JoshuaKGoldberg merged commit 44fbd41 into main Jan 29, 2026
11 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the watcher-ignores branch January 29, 2026 20:55
This was referenced Jan 31, 2026
Merged
Open
JoshuaKGoldberg pushed a commit that referenced this pull request Mar 1, 2026
@lishaduck @auvred
refactor: use host for watcher (#2200)
c504693 
<!-- 👋 Hi, thanks for sending a PR to flint! ❤️‍🔥
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: followup to
#2168, as approved for addressing
by Josh in
#2168 (review).
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/flint-fyi/flint/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/flint-fyi/flint/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

<!-- Description of what is changed and how the code change does that.
-->
❤️‍🔥

I don't remember if this works, I whipped this up on a 6-hour car ride
to Oklahoma yesterday.

---------

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

1 approval One team member approved; we're now waiting for a second approval or for 2 business days to pass.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lishaduck @JoshuaKGoldberg