Repository navigation
perf(cake_gdn_kcp): with grad, graph-replay checkpoint recompute hands its tapes to the backward #8638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
perf(cake_gdn_kcp): with grad, graph-replay checkpoint recompute hands its tapes to the backward #8638
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c1cba34
cake_gdn_train_kcp: hand the recompute tapes to the backward under gr…
averyhNV ec437e8
cake_gdn_train_kcp: route-qualify the reuse_recompute_tapes graph note
averyhNV d209955
cake_gdn_train_kcp: review fixes of the graph-replay tape hand-off
averyhNV a083116
cake_gdn_train_kcp: size rule for the graph-replay tape hand-off
averyhNV c7c024b
cake_gdn_train_kcp: read the graph-replay size rule once per recompute
averyhNV 4ddfeb4
cake_gdn_train_kcp: model the graph-replay tape hand-off in the works…
averyhNV 35793c8
cake_gdn_train_kcp: review fixes of the graph-replay hand-off tests a…
averyhNV a0ca137
Merge branch 'main' into fi-8063-gdn-r8a
yyihuang 2da5108
Merge branch 'main' into fi-8063-gdn-r8a
averyhNV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: flashinfer-ai/flashinfer
Length of output: 14739
Script executed:
Repository: flashinfer-ai/flashinfer
Length of output: 4242
Explicit
"auto"on the deterministic replay route is accepted instead of refused._options_formaps every"auto"value on the deterministic route toNone. The deterministicOptionsDetKcpthen resolvesNonetoFalseundergraph="replay". A caller who passesOptionsKcp(graph="replay", reuse_recompute_tapes="auto")therefore runs with tape reuse off and receives no error. The facade docstring says an explicit"auto"is refused under replay on this route.The conversion cannot tell the two cases apart.
OptionsKcpstores the same"auto"for an omitted argument and an explicit one. Rejecting"auto"before conversion would also reject the defaultOptionsKcp(graph="replay"), which the facade supports. The fix needs a way to record whether the value was supplied.