-
Notifications
You must be signed in to change notification settings - Fork 840
chore: Update XFails Report #2287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
flashinfer-bot
wants to merge
1
commit into
main
Choose a base branch
from
auto-update-xfails-report
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+106
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| Scanning for test files in /home/runner/work/flashinfer/flashinfer/tests... | ||
| Found 125 test files | ||
| Collecting xfail markers... | ||
| ==================================================================================================== | ||
| XFAILS REPORT | ||
| ==================================================================================================== | ||
|
|
||
| Total xfails: 11 | ||
| Unique reasons: 9 | ||
|
|
||
|
|
||
| ---------------------------------------------------------------------------------------------------- | ||
| Reason Count Type | ||
| ---------------------------------------------------------------------------------------------------- | ||
| Expected failure for SM120/121 for now since the tile s... 2 decorator | ||
| NOTE(Zihao): temporarily disable cuda graph until we fu... 2 runtime | ||
| NOTE(Zihao): attention sink with sliding window and non... 1 runtime | ||
| seq_len=514 is known to fail in full test suite occasio... 1 parameter | ||
| nvidia-cutlass-dsl has issue when l=1 1 runtime | ||
| str(e) 1 runtime | ||
| state_dtype=float32 not yet supported (only float16/bfl... 1 decorator | ||
| Note(jimmzhou): Make MxFP4xBf16 nonfunctional on SM103 ... 1 runtime | ||
| Numerical accuracy issue on SM 121 (Spark) 1 decorator | ||
| ---------------------------------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| ==================================================================================================== | ||
| DETAILED BREAKDOWN BY REASON | ||
| ==================================================================================================== | ||
|
|
||
| [2 xfails] Expected failure for SM120/121 for now since the tile size/number of stages is too large. | ||
| ---------------------------------------------------------------------------------------------------- | ||
| • tests/attention/test_batch_attention.py:211 | ||
| Test: test_batch_attention_with_noncontiguous_q | ||
| Type: decorator | ||
| Condition: get_compute_capability(torch.device(device='cuda'))[0] == 12 | ||
|
|
||
| • tests/attention/test_batch_attention.py:260 | ||
| Test: test_batch_attention_correctness | ||
| Type: decorator | ||
| Condition: get_compute_capability(torch.device(device='cuda'))[0] == 12 | ||
|
|
||
|
|
||
| [2 xfails] NOTE(Zihao): temporarily disable cuda graph until we fully fix the workspace buffer overflow issue for prefill + cudagraph | ||
| ---------------------------------------------------------------------------------------------------- | ||
| • tests/attention/test_batch_prefill_kernels.py:81 | ||
| Test: test_batch_prefill_with_paged_kv_cache | ||
| Type: runtime | ||
|
|
||
| • tests/attention/test_batch_prefill_kernels.py:321 | ||
| Test: test_batch_prefill_with_tuple_paged_kv_cache | ||
| Type: runtime | ||
|
|
||
|
|
||
| [1 xfails] NOTE(Zihao): attention sink with sliding window and non-causal will fail after https://github.com/flashinfer-ai/flashinfer/pull/1661, temporarily xfail the test. | ||
| ---------------------------------------------------------------------------------------------------- | ||
| • tests/attention/test_attention_sink.py:643 | ||
| Test: test_attention_sink_chunk_prefill | ||
| Type: runtime | ||
|
|
||
|
|
||
| [1 xfails] seq_len=514 is known to fail in full test suite occasionally | ||
| ---------------------------------------------------------------------------------------------------- | ||
| • tests/attention/test_xqa.py:138 | ||
| Test: test_xqa | ||
| Type: parameter | ||
| Strict: False | ||
|
|
||
|
|
||
| [1 xfails] nvidia-cutlass-dsl has issue when l=1 | ||
| ---------------------------------------------------------------------------------------------------- | ||
| • tests/gemm/test_cute_dsl_blockscaled_gemm.py:93 | ||
| Test: test_blockscaled_gemm_python_interface | ||
| Type: runtime | ||
|
|
||
|
|
||
| [1 xfails] str(e) | ||
| ---------------------------------------------------------------------------------------------------- | ||
| • tests/gemm/test_mm_fp4.py:97 | ||
| Test: _test_mm_fp4 | ||
| Type: runtime | ||
|
|
||
|
|
||
| [1 xfails] state_dtype=float32 not yet supported (only float16/bfloat16) | ||
| ---------------------------------------------------------------------------------------------------- | ||
| • tests/mamba/test_chunk_scan_combined.py:1989 | ||
| Test: test_fp32_state_dtype | ||
| Type: decorator | ||
| Strict: True | ||
|
|
||
|
|
||
| [1 xfails] Note(jimmzhou): Make MxFP4xBf16 nonfunctional on SM103 to avoid B200 regression | ||
| ---------------------------------------------------------------------------------------------------- | ||
| • tests/moe/utils.py:158 | ||
| Test: skip_checks | ||
| Type: runtime | ||
|
|
||
|
|
||
| [1 xfails] Numerical accuracy issue on SM 121 (Spark) | ||
| ---------------------------------------------------------------------------------------------------- | ||
| • tests/utils/test_jit_example.py:173 | ||
| Test: test_dump_logits | ||
| Type: decorator | ||
| Condition: get_compute_capability(torch.device('cuda:0')) == (12, 1) | ||
|
|
||
| ==================================================================================================== | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The xfail reason
str(e)is not descriptive and makes the report less useful. This is caused by the use ofpytest.xfail(str(e))intests/gemm/test_mm_fp4.pyon line 92. The static analysis script that generates this report cannot resolve the value ofstr(e)and therefore uses the literal code as the reason.To improve this, the
pytest.xfailcall should be updated to use a descriptive string literal. Based on the context in the test file, a more informative reason would be something like:"cuDNN backend for FP4 GEMM with mxfp4 on SM120+ requires cuDNN 9.14.0+"This change would make the xfail report more understandable and aid in tracking test failures.