Skip to content

chore: Update XFails Report#2287

Open
flashinfer-bot wants to merge 1 commit intomainfrom
auto-update-xfails-report
Open

chore: Update XFails Report#2287
flashinfer-bot wants to merge 1 commit intomainfrom
auto-update-xfails-report

Conversation

@flashinfer-bot
Copy link
Copy Markdown
Collaborator

@flashinfer-bot flashinfer-bot commented Jan 5, 2026

Summary

This PR updates the xfails report based on the current test suite.

Changes

  • Updated reports/xfails_report.txt with current xfail markers from the test suite

How to Review

  1. Review the changes to reports/xfails_report.txt
  2. Check if the number of xfails has increased or decreased
  3. Review the reasons for any new xfails
  4. Consider addressing xfails that may no longer be needed

Notes

  • This is an automated PR generated weekly
  • The report shows all pytest.mark.xfail markers in the test suite
  • Grouped by reason for easy analysis

🤖 This PR was automatically generated by the update-xfails-report workflow

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @flashinfer-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automatically updates the xfails_report.txt to provide an accurate and current overview of all expected test failures within the project's test suite. This ensures that developers have the latest information on known issues, categorized by reason, to facilitate analysis and potential resolution.

Highlights

  • XFails Report Update: The reports/xfails_report.txt file has been updated to reflect the current pytest.mark.xfail markers across the test suite. This report provides a detailed breakdown of 10 xfails across 8 unique reasons, including issues related to SM120/121, CUDA graph, attention sink, seq_len=514 failures, nvidia-cutlass-dsl issues, and numerical accuracy problems.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 5, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
📝 Walkthrough

Walkthrough

Added a new static artifact reports/xfails_report.txt that aggregates pytest xfail data: totals, summarized reasons with counts/types, and detailed per-reason breakdowns of affected test files, tests, xfail types, and conditions. No runtime code changed.

Changes

Cohort / File(s) Summary
New Report Artifact
reports/xfails_report.txt
Added a static xfails report capturing totals, unique reasons, a summarized reasons/counts table, and detailed per-reason breakdowns listing affected test files, test names, xfail types, and conditions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • jimmyzho
  • yzh119

Poem

🐇📋 I hopped through logs by moonlight bright,
Counting xfails one by one tonight,
Reasons like carrots, tidy in a row,
I listed tests where flaky breezes blow,
A rabbit scribe—soft, steady, light.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description includes a summary, changes overview, and review guidance, but does not fully follow the repository's template structure with required sections like Description, Related Issues, and Pre-commit Checks. Restructure the description to follow the template: add a Description section, Related Issues section, and complete the Pre-commit Checks and Tests checklist items with appropriate selections.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: Update XFails Report' clearly describes the main change: updating the xfails report file to reflect current test suite markers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch auto-update-xfails-report

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the automated xfails report. The report is well-structured, but I've identified one expected failure that uses a non-descriptive reason, str(e). This originates from the test file tests/gemm/test_mm_fp4.py where pytest.xfail is called with a dynamic value. Using a descriptive string literal instead would improve the clarity and utility of this report. My specific comment provides more detail on this.

Comment on lines +76 to +80
[1 xfails] str(e)
----------------------------------------------------------------------------------------------------
• tests/gemm/test_mm_fp4.py:92
Test: _test_mm_fp4
Type: runtime
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The xfail reason str(e) is not descriptive and makes the report less useful. This is caused by the use of pytest.xfail(str(e)) in tests/gemm/test_mm_fp4.py on line 92. The static analysis script that generates this report cannot resolve the value of str(e) and therefore uses the literal code as the reason.

To improve this, the pytest.xfail call should be updated to use a descriptive string literal. Based on the context in the test file, a more informative reason would be something like:

"cuDNN backend for FP4 GEMM with mxfp4 on SM120+ requires cuDNN 9.14.0+"

This change would make the xfail report more understandable and aid in tracking test failures.

@flashinfer-bot flashinfer-bot force-pushed the auto-update-xfails-report branch from 812cc1a to c626501 Compare January 12, 2026 01:48
@flashinfer-bot flashinfer-bot force-pushed the auto-update-xfails-report branch from c626501 to 5af35b4 Compare January 19, 2026 01:48
@flashinfer-bot flashinfer-bot force-pushed the auto-update-xfails-report branch from 5af35b4 to e4d637c Compare January 26, 2026 01:52
@flashinfer-bot flashinfer-bot force-pushed the auto-update-xfails-report branch from e4d637c to 055e40b Compare February 2, 2026 02:07
@flashinfer-bot flashinfer-bot force-pushed the auto-update-xfails-report branch 2 times, most recently from 7fd2a5b to 3e030ff Compare February 16, 2026 02:06
@flashinfer-bot flashinfer-bot force-pushed the auto-update-xfails-report branch from 3e030ff to ba1d24a Compare February 23, 2026 02:07
@flashinfer-bot flashinfer-bot force-pushed the auto-update-xfails-report branch from ba1d24a to 2d57090 Compare March 9, 2026 02:05
@flashinfer-bot flashinfer-bot force-pushed the auto-update-xfails-report branch 2 times, most recently from b7775e3 to 24aa184 Compare March 23, 2026 02:10
Auto-generated xfails report based on current test suite markers.
@flashinfer-bot flashinfer-bot force-pushed the auto-update-xfails-report branch from 24aa184 to c4d5ec9 Compare March 30, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant