Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/authorized_codeowner.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ azhurkevich
bkryu
cyx-6
dierksen
djmmoss
IwakuraRein
jiahanc
Comment on lines +8 to +10
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new entries are correctly placed to maintain alphabetical order, which is great for readability. To ensure this file remains sorted in the future and prevent manual errors, consider adding a check to your CI pipeline or a pre-commit hook. Since the project uses pre-commit (as mentioned in the PR template), you could add a hook to .pre-commit-config.yaml to automate this check. For example:

-   repo: local
    hooks:
    -   id: check-sorted-owners
        name: Check that authorized_codeowner.txt is sorted
        entry: bash -c 'if ! sort -C -f scripts/authorized_codeowner.txt; then echo "scripts/authorized_codeowner.txt is not sorted! Please sort it alphabetically (case-insensitive)." && exit 1; fi'
        language: system
        files: ^scripts/authorized_codeowner.txt$

This would improve the long-term maintainability of this file by ensuring it always stays sorted.

joker-eph
kahyunnam
kaixih
Expand Down