Skip to content

chore: update the list of authorized codeowners#1970

Merged
yzh119 merged 1 commit intoflashinfer-ai:mainfrom
yzh119:update-authorized-codeowner
Oct 24, 2025
Merged

chore: update the list of authorized codeowners#1970
yzh119 merged 1 commit intoflashinfer-ai:mainfrom
yzh119:update-authorized-codeowner

Conversation

@yzh119
Copy link
Copy Markdown
Collaborator

@yzh119 yzh119 commented Oct 23, 2025

📌 Description

Add @djmmoss @jiahanc to the authorized codeowner list.

🔍 Related Issues

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit (or used your preferred method).
  • I have installed the hooks with pre-commit install.
  • I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

  • Tests have been added or updated as needed.
  • All tests are passing (unittest, etc.).

Reviewer Notes

Summary by CodeRabbit

  • Chores
    • Updated internal codeowner authorization configuration.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @yzh119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine maintenance task by updating the list of authorized codeowners. The primary purpose is to officially recognize two new members as codeowners, ensuring proper review assignments and ownership within the codebase.

Highlights

  • Codeowner Updates: Two new individuals, @djmmoss and @jiahanc, have been added to the list of authorized codeowners.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 23, 2025

Walkthrough

Two new codeowners are added to the authorized codeowners configuration file: djmmoss is inserted after dierksen and jiahanc after IwakuraRein. No other modifications are made to the file.

Changes

Cohort / File(s) Summary
Codeowner Configuration Updates
scripts/authorized_codeowner.txt
Added two new authorized codeowners: djmmoss and jiahanc

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Two new guardians join the authorized fold,
djmmoss and jiahanc, brave and bold,
In the scripts they'll help keep order and care,
While we hop through the code with flair! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "chore: update the list of authorized codeowners" directly and accurately reflects the main change in the pull request. The changeset adds two new codeowners (@djmmoss and @jiahanc) to the authorized codeowners list, and the title clearly conveys this update. The title is concise, specific, and uses proper conventional prefix notation, making it easy for teammates to understand the primary change when scanning the repository history.
Description Check ✅ Passed The pull request description includes all major sections required by the repository's PR template, including the Description section with a clear explanation of the changes ("Add @djmmoss @jiahanc to the authorized codeowner list"), the Related Issues placeholder, the Pre-commit Checks section, the Tests section, and the Reviewer Notes section. While some items like the checklists are unchecked and the Related Issues section is left as a placeholder, the core description content is complete and appropriate for this administrative change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0260ab3 and 3b8b6e2.

📒 Files selected for processing (1)
  • scripts/authorized_codeowner.txt (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Deploy Docs
🔇 Additional comments (1)
scripts/authorized_codeowner.txt (1)

8-8: LGTM!

Both new codeowners are correctly inserted in alphabetical order: djmmoss after dierksen and jiahanc after IwakuraRein. The entries follow the existing naming convention consistently.

Also applies to: 10-10


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds two new users to the scripts/authorized_codeowner.txt file. The change is straightforward and maintains the alphabetical sorting of the list. I have added one suggestion to help automate the sorting check in the future, which would improve the long-term maintainability of this file.

Comment on lines +8 to +10
djmmoss
IwakuraRein
jiahanc
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new entries are correctly placed to maintain alphabetical order, which is great for readability. To ensure this file remains sorted in the future and prevent manual errors, consider adding a check to your CI pipeline or a pre-commit hook. Since the project uses pre-commit (as mentioned in the PR template), you could add a hook to .pre-commit-config.yaml to automate this check. For example:

-   repo: local
    hooks:
    -   id: check-sorted-owners
        name: Check that authorized_codeowner.txt is sorted
        entry: bash -c 'if ! sort -C -f scripts/authorized_codeowner.txt; then echo "scripts/authorized_codeowner.txt is not sorted! Please sort it alphabetically (case-insensitive)." && exit 1; fi'
        language: system
        files: ^scripts/authorized_codeowner.txt$

This would improve the long-term maintainability of this file by ensuring it always stays sorted.

@yzh119 yzh119 enabled auto-merge (squash) October 24, 2025 00:10
@yzh119 yzh119 merged commit 1eebf02 into flashinfer-ai:main Oct 24, 2025
4 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 27, 2025
@coderabbitai coderabbitai bot mentioned this pull request Nov 10, 2025
@coderabbitai coderabbitai bot mentioned this pull request Dec 12, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants