Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve extensibility of WelcomeHero #4199

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

DavideIadeluca
Copy link
Contributor

2.x port of #4039

Progresses #4060

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca marked this pull request as ready for review February 17, 2025 19:40
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner February 17, 2025 19:40
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if introducing a reusable hero component would be even better for extensibility/theming

it could be composition based:

or something like that? doesn't necessarily have to be done in this PR, but would love the feedback on that before 2.0 goes stable

@DavideIadeluca
Copy link
Contributor Author

Yeah, I think it would certainly be worth it to have a go and see how it goes. Would prefer if this is done in a separate PR though

@SychO9 SychO9 changed the title refactor(core): improve extensibility of WelcomeHero feat: improve extensibility of WelcomeHero Feb 22, 2025
@SychO9 SychO9 added this to the 2.0.0-beta.3 milestone Feb 22, 2025
@SychO9 SychO9 merged commit 0ca99dc into flarum:2.x Feb 22, 2025
21 checks passed
@DavideIadeluca DavideIadeluca deleted the di/welcome-hero-extensibility branch February 22, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants