Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Reusable Hero Component #4202

Open
DavideIadeluca opened this issue Feb 22, 2025 · 0 comments
Open

Create Reusable Hero Component #4202

DavideIadeluca opened this issue Feb 22, 2025 · 0 comments
Labels
type/bug

Comments

@DavideIadeluca
Copy link
Contributor

DavideIadeluca commented Feb 22, 2025 •
edited
Loading

Follow up of #4199 (review)

Current Behavior

There are a multitude of Hero like components & Elements across the codebase. Examples:

  • WelcomeHero
  • DiscussionHero
  • TagHero
  • MessagesPage hero

Steps to Reproduce

N/A

Expected Behavior

For extensibility purposes, it would be worth it to try to create a single reusable Hero component which can be extended

Screenshots

No response

Environment

N/A

Output of php flarum info

No response

Possible Solution

No response

Additional Context

#4199 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavideIadeluca