-
Notifications
You must be signed in to change notification settings - Fork 63
Update outdated tools version in github action #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
50167f5
Update outdated tools version in github action
sanketsudake 9869813
Organize code
sanketsudake e4ca118
Try job name
sanketsudake 68296a0
Take dump if failure
sanketsudake e27b9ad
fix action
sanketsudake b7ebd5a
Fix nodejs action for LTS
sanketsudake d5f8edf
further fixes
sanketsudake 5337da4
Minor changes
sanketsudake 286079e
uncomment exception capturing
sanketsudake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: 'Collect Fission Dump' | ||
| description: 'Collects Fission dump on job failure' | ||
| inputs: | ||
| workflow-name: | ||
| description: 'Name of the workflow' | ||
| required: true | ||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Collect Fission Dump | ||
| shell: bash | ||
| run: | | ||
| command -v fission && fission support dump | ||
|
|
||
| - name: Archive fission dump | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ inputs.workflow-name }}-fission-dump | ||
| path: fission-dump/*.zip | ||
| retention-days: 5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| name: 'Setup Fission Environment' | ||
| description: 'Sets up Helm, Kind cluster, Fission CLI, and completes base Fission setup' | ||
| inputs: | ||
| kind-node-image: | ||
| description: 'Kind node image to use' | ||
| required: false | ||
| default: 'kindest/node:v1.27.16' | ||
| kind-version: | ||
| description: 'Kind version to use' | ||
| required: false | ||
| default: 'v0.23.0' | ||
| helm-version: | ||
| description: 'Helm version to use' | ||
| required: false | ||
| default: 'v3.18.4' | ||
| kind-config: | ||
| description: 'Kind config file' | ||
| required: false | ||
| default: 'kind.yaml' | ||
| fission-cli-version: | ||
| description: 'Fission CLI version to install' | ||
| required: false | ||
| default: 'v1.21.0' | ||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Helm | ||
| uses: Azure/setup-helm@5119fcb9089d432beecbf79bb2c7915207344b78 # v3.5 | ||
| with: | ||
| version: ${{ inputs.helm-version }} | ||
|
|
||
| - name: Kind Cluster | ||
| uses: engineerd/setup-kind@v0.5.0 | ||
| with: | ||
| image: ${{ inputs.kind-node-image }} | ||
| version: ${{ inputs.kind-version }} | ||
| config: ${{ inputs.kind-config }} | ||
|
|
||
| - name: Configuring and testing the Installation | ||
| shell: bash | ||
| run: | | ||
| kubectl cluster-info --context kind-kind | ||
| kind get kubeconfig >$HOME/.kube/config | ||
| kubectl get nodes | ||
|
|
||
| # Base Setup Steps (merged from fission-base-setup) | ||
| - name: Base Setup | ||
| shell: bash | ||
| run: | | ||
| make verify-kind-cluster | ||
| make install-fission-cli | ||
| make install-skaffold | ||
| make create-crds | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # GitHub Actions Workflow for Fission Environments | ||
|
|
||
| This directory contains the GitHub Actions workflow configuration for building and testing Fission environments. | ||
|
|
||
| ## Structure | ||
|
|
||
| - `environment.yaml`: Main workflow file that defines jobs for all environments | ||
| - `actions/`: Directory containing reusable composite actions | ||
| - `setup-cluster/`: Sets up Helm, Kind cluster, Fission CLI and runs the base Fission setup | ||
| - `collect-fission-dump/`: Collects and archives Fission dumps | ||
| - `filters/`: Contains path filters for detecting changes | ||
|
|
||
| ## Composite Actions | ||
|
|
||
| The workflow uses two main composite actions to reduce duplication: | ||
|
|
||
| 1. **setup-cluster**: Sets up the complete infrastructure needed for testing (Helm, Kind, Fission CLI) and performs base Fission setup steps | ||
| 2. **collect-fission-dump**: Collects and archives Fission dumps on failure | ||
|
|
||
| ## Environment Variables | ||
|
|
||
| All version pins are centralized in the `env` section of the main workflow file: | ||
|
|
||
| - `KIND_NODE_IMAGE`: Kind node image version | ||
| - `KIND_VERSION`: Kind tool version | ||
| - `HELM_VERSION`: Helm version | ||
| - `FISSION_CLI_VERSION`: Fission CLI version | ||
| - `KIND_CONFIG`: Path to Kind configuration | ||
| - `FISSION_VERSION`: Fission version | ||
|
|
||
| ## Usage | ||
|
|
||
| The workflow is triggered on pull requests to the `master` branch. It first runs a change detection job to determine which environments have been modified, then runs the relevant jobs for those environments. | ||
|
|
||
| ### Adding a New Environment | ||
|
|
||
| To add a new environment: | ||
|
|
||
| 1. Add the environment to the `check` job's outputs | ||
| 2. Create a new job for the environment following the existing patterns | ||
| 3. Add the environment to the filters configuration |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'make install-fission-cli' step is redundant since the Fission CLI is already installed in the previous step. This duplication could cause confusion or unexpected behavior.