Skip to content

Update outdated tools version in github action#423

Merged
sanketsudake merged 9 commits intomasterfrom
update-github-action-versions
Aug 8, 2025
Merged

Update outdated tools version in github action#423
sanketsudake merged 9 commits intomasterfrom
update-github-action-versions

Conversation

@sanketsudake
Copy link
Member

No description provided.

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates various tool versions in the GitHub Actions workflow and consolidates duplicated setup steps using reusable composite actions.

  • Updates Fission version from v1.20.3 to v1.21.0 across configuration files
  • Updates environment versions for Python (1.34.2 → 1.34.3) and NodeJS (1.32.4 → 1.32.5)
  • Refactors GitHub Actions workflow to use composite actions for setup and cleanup tasks

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
skaffold.yaml Updates Fission chart version to v1.21.0
rules.mk Updates FISSION_VERSION variable to v1.21.0
python/envconfig.json Bumps Python environment version to 1.34.3
nodejs/envconfig.json Bumps NodeJS environment versions to 1.32.5
.github/workflows/environment.yaml Refactors workflow to use composite actions and updates checkout action
.github/workflows/README.md Adds documentation for the workflow structure
.github/actions/setup-cluster/action.yml Creates reusable action for cluster setup
.github/actions/collect-fission-dump/action.yml Creates reusable action for collecting Fission dumps

shell: bash
run: |
make verify-kind-cluster
make install-fission-cli
Copy link

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'make install-fission-cli' step is redundant since the Fission CLI is already installed in the previous step. This duplication could cause confusion or unexpected behavior.

Suggested change
make install-fission-cli

Copilot uses AI. Check for mistakes.
command -v fission && fission support dump

- name: Archive fission dump
if: ${{ always() }}
Copy link

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Archive step should use 'if: ${{ failure() }}' instead of 'if: ${{ always() }}' to only upload artifacts when there's actually a failure, matching the original workflow behavior.

Suggested change
if: ${{ always() }}
if: ${{ failure() }}

Copilot uses AI. Check for mistakes.
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake merged commit 863298b into master Aug 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants