Update outdated tools version in github action#423
Merged
sanketsudake merged 9 commits intomasterfrom Aug 8, 2025
Merged
Conversation
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Closed
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates various tool versions in the GitHub Actions workflow and consolidates duplicated setup steps using reusable composite actions.
- Updates Fission version from v1.20.3 to v1.21.0 across configuration files
- Updates environment versions for Python (1.34.2 → 1.34.3) and NodeJS (1.32.4 → 1.32.5)
- Refactors GitHub Actions workflow to use composite actions for setup and cleanup tasks
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| skaffold.yaml | Updates Fission chart version to v1.21.0 |
| rules.mk | Updates FISSION_VERSION variable to v1.21.0 |
| python/envconfig.json | Bumps Python environment version to 1.34.3 |
| nodejs/envconfig.json | Bumps NodeJS environment versions to 1.32.5 |
| .github/workflows/environment.yaml | Refactors workflow to use composite actions and updates checkout action |
| .github/workflows/README.md | Adds documentation for the workflow structure |
| .github/actions/setup-cluster/action.yml | Creates reusable action for cluster setup |
| .github/actions/collect-fission-dump/action.yml | Creates reusable action for collecting Fission dumps |
| shell: bash | ||
| run: | | ||
| make verify-kind-cluster | ||
| make install-fission-cli |
There was a problem hiding this comment.
The 'make install-fission-cli' step is redundant since the Fission CLI is already installed in the previous step. This duplication could cause confusion or unexpected behavior.
Suggested change
| make install-fission-cli |
| command -v fission && fission support dump | ||
|
|
||
| - name: Archive fission dump | ||
| if: ${{ always() }} |
There was a problem hiding this comment.
The Archive step should use 'if: ${{ failure() }}' instead of 'if: ${{ always() }}' to only upload artifacts when there's actually a failure, matching the original workflow behavior.
Suggested change
| if: ${{ always() }} | |
| if: ${{ failure() }} |
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
soharab-ic
approved these changes
Aug 8, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.