Rebase to 5.3.3+ branch + update UG Chapter 13#7
Merged
fisidi merged 15 commits intofisidi:wrfcmaqv533+from May 10, 2022
Merged
Rebase to 5.3.3+ branch + update UG Chapter 13#7fisidi merged 15 commits intofisidi:wrfcmaqv533+from
fisidi merged 15 commits intofisidi:wrfcmaqv533+from
Conversation
deleted: UTIL/create_ebi/src_RXNSU/junit.f deleted: UTIL/inline_phot_preproc/src/CSQY_DATA.F deleted: UTIL/inline_phot_preproc/src/CSQY_DATA.f deleted: UTIL/inline_phot_preproc/src/CSQY_DATA_gen.f deleted: UTIL/inline_phot_preproc/src/CSQY_DATA_old.f remove case dependendent file names or unneeded files
-restore wanted files
-replace with .F version
minor edit
-changed junit.o to depend on junit.F
modified: UTIL/create_ebi/scripts/bldrun_create_ebi.csh
-changed path account for build-run script is in scripts subdirectory
-change comment line on assumed path
modified: UTIL/inline_phot_preproc/bldrun.inline_phot_preproc.csh
-changed setting of CMAQ repository to relative path
Remove files from chemistry utilities causing problems on MAC and WINDOWS systems. Thank you @bhutzell for resolving this issue.
fisidi
reviewed
May 9, 2022
fisidi
reviewed
May 9, 2022
fisidi
reviewed
May 9, 2022
fisidi
approved these changes
May 9, 2022
Owner
fisidi
left a comment
fisidi
left a comment
There was a problem hiding this comment.
Apart from the few comments I had, I don't see anything other outstanding issue.
Any additional information can be added in the upcoming v5.4 release.
Approved!
Clarify that the new WRF-CMAQ model is based on WRFv4.4 and CMAQv5.3.3.3 (to be tagged today).
remove wrfcmaq_twoway_coupler link
Author
|
Thanks for the fast review! I made the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the recent updates to the 5.3.3+ branch related to Bill bugfix for windows (basically getting your PR up to date with v5.3.3+).
The other change is I updated the WRF and CMAQ version numbers in section 13.4 as well as the name of the WRF-CMAQ tutorial. I also removed sections 13.5 and 13.6. Please confirm you agree with this deletion. The namelist information in 13.6 is already in your tutorial and the benchmarking data info does not apply to this release. However we should remember to move the benchmark information into the tutorial for the v5.4 release once we have a new benchmark. I'm not sure why we had it in this chapter rather than the tutorial in the first place.