Remove files from chemistry utilities causing problems on MAC and WINDOWS systems.#171
Merged
kmfoley merged 6 commits intoUSEPA:5.3.3+from May 7, 2022
Merged
Conversation
deleted: UTIL/create_ebi/src_RXNSU/junit.f deleted: UTIL/inline_phot_preproc/src/CSQY_DATA.F deleted: UTIL/inline_phot_preproc/src/CSQY_DATA.f deleted: UTIL/inline_phot_preproc/src/CSQY_DATA_gen.f deleted: UTIL/inline_phot_preproc/src/CSQY_DATA_old.f remove case dependendent file names or unneeded files
-restore wanted files
-replace with .F version
minor edit
-changed junit.o to depend on junit.F
modified: UTIL/create_ebi/scripts/bldrun_create_ebi.csh
-changed path account for build-run script is in scripts subdirectory
-change comment line on assumed path
modified: UTIL/inline_phot_preproc/bldrun.inline_phot_preproc.csh
-changed setting of CMAQ repository to relative path
bhutzell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contact:
Bill Hutzell/USEPA at hutzell.bill@epa.gov
Type of code change:
bug fix
Description of changes:
Both the create_ebi and inline_phot_prerproc utilities have files in their source code directories that only differ in letter case in filenames such as UTIL/create_ebi/junit.F and UTIL/create_ebi/junit.f. The property does not cause problems on Linux systems but can cause problems on Window and Macintosh systems. The problem is easily removed because either, only one file is needed or neither file is needed to build these chemistry utilities. The pull request removes the unneeded files causing the problems and updates the makefile for the create_ebi utility. It also removes two unneeded files under UTIL/inline_phot_preproc/src while makes minor changes to build-run scripts for create_ebi and inline_phot_preproc.
Issue:
CMAQ public repository Issue #169
Summary of Impact:
None, but allows to more efficiently use the CMAQ repository and its utilities on Windows and Macintosh operating systems.
Tests conducted: