Skip to content

Conversation

@fangn2
Copy link
Contributor

@fangn2 fangn2 commented Jul 10, 2023

Issue #, if available:

Description of changes:
Upgrade minimum go to 1.17 to unblock dependency golang.org/x/net update PR #497 which requires go 1.17+.
Currently it's failing with error:

go build -o snapshot-example
--
  | go: downloading golang.org/x/sys v0.8.0
  | # golang.org/x/sys/unix
  | ../../../../../../../go/pkg/mod/golang.org/x/[email protected]/unix/syscall.go:83:16: undefined: unsafe.Slice
  | ../../../../../../../go/pkg/mod/golang.org/x/[email protected]/unix/syscall_linux.go:1018:20: undefined: unsafe.Slice
  | ../../../../../../../go/pkg/mod/golang.org/x/[email protected]/unix/syscall_linux.go:2297:9: undefined: unsafe.Slice
  | ../../../../../../../go/pkg/mod/golang.org/x/[email protected]/unix/syscall_unix.go:118:7: undefined: unsafe.Slice
  | ../../../../../../../go/pkg/mod/golang.org/x/[email protected]/unix/sysvshm_unix.go:33:7: undefined: unsafe.Slice
  | note: module requires Go 1.17
  | make: *** [Makefile:73: snapshot-example] Error 2
  | 🚨 Error: The command exited with status 2
  | user command error: exit status 2


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@fangn2 fangn2 requested a review from a team as a code owner July 10, 2023 18:26
Copy link
Contributor

@swagatbora90 swagatbora90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good to merge provided CI steps are passing.

@fangn2
Copy link
Contributor Author

fangn2 commented Jul 10, 2023

Buildkite CI is failing on building Firecracker from tip of Firecracker's main branch which is not related to this change.
The CI has been failing for the same reason in the last 9 consecutive nightly builds.

@fangn2 fangn2 merged commit 50e3946 into firecracker-microvm:main Jul 10, 2023
@fangn2 fangn2 deleted the upgrade-go-to-1.7 branch July 10, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants