Add support for snapshot memory backend #495
Conversation
bduffany
force-pushed
the
support-uffd-backend
branch
from
b4c1912 to
fbc3f74
Compare
bduffany
force-pushed
the
support-uffd-backend
branch
2 times, most recently
from
63818b6 to
3a80903
Compare
- Pull in upstream swagger definitions for SnapshotLoadParams and MemoryBackend - Run `go generate` - Update Snapshot config to allow setting MemBackend - Forward the MemBackend through to the Firecracker client Signed-off-by: Brandon Duffany <[email protected]>
bduffany
force-pushed
the
support-uffd-backend
branch
from
3a80903 to
62f8e17
Compare
|
Friendly ping @kzys - we have gotten this patch working successfully over in https://github.com/buildbuddy-io/buildbuddy. I'm not sure why the CI tests are failing though - the failed test doesn't seem to show any output. |
fangn2
left a comment
fangn2
left a comment
There was a problem hiding this comment.
Thanks for your PR!
Overall looks good to me, I left some comments.
Regarding CI failure, rebase main should resolve it(had some changes on CI recently).
fangn2
left a comment
fangn2
left a comment
There was a problem hiding this comment.
Thanks for your PR!
Overall looks good to me, I left some comments.
Regarding CI failure, rebase main should resolve it(had some changes on CI recently).
Signed-off-by: Brandon Duffany <[email protected]>
bduffany
force-pushed
the
support-uffd-backend
branch
from
e5334b9 to
7b904b1
Compare
Signed-off-by: Brandon Duffany <[email protected]>
|
I went ahead and bumped the firecracker version to v1.4.0 since MemoryBackend is not supported in v1.0.0. I am not sure if the version bump will break anything else, though. |
Signed-off-by: Brandon Duffany <[email protected]>
Signed-off-by: Brandon Duffany <[email protected]>
bduffany
left a comment
bduffany
left a comment
There was a problem hiding this comment.
CI is failing due to "go: command not found".
I merged main into this branch - hopefully that fixes CI. Let me know if I should have rebased, or if there's anything else I should do to clean up the commits. (I assumed you will squash commits when merging into main.)
CI is working as expected. |
Signed-off-by: Brandon Duffany <[email protected]>
Fixed with c51a40b - this assertion was unnecessary, I think. |
|
Please clean up the commits before merging. I think we should keep the commit to upgrade firecracker ver to v1.4.0 as is and squash the rest |
|
nvm, looks like its already merged |
3 participants
go generate