Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firecamp Desktop App #164

Merged
merged 78 commits into from
Mar 4, 2024
Merged

Firecamp Desktop App #164

merged 78 commits into from
Mar 4, 2024

Conversation

Nishchit14
Copy link
Contributor

#62

@Nishchit14
Copy link
Contributor Author

@LukeHagar Thanks for forking the repo, First you can run the app in web mode with pnpm dev command. You can contribute whatever you wish there. If anything specific to the desktop app, you can consider pakcages/firecamp-electron directory to navigate. just run pnpm start to open the local desktop app.

@Nishchit14
Copy link
Contributor Author

@jsoref Can you please help here why the job is failing?

@jsoref
Copy link
Contributor

jsoref commented Mar 4, 2024

@Nishchit14: so, there are a few things here, one is to change Typescript to TypeScript

The second is that
b000709 introduced an empty log file https://github.com/firecamp-dev/firecamp/blob/b000709b6525c4a55ed30e48f36625a027bbf82f/packages/firecamp-desktop/src-tauri/rustc-ice-2023-08-29T12:21:32.539513Z-24344.txt and 3a030cc introduced an empty log file in https://github.com/firecamp-dev/firecamp/blob/3a030cc052e076840445e4aeeba2e462fa445976/packages/firecamp-desktop/src-tauri/rustc-ice-2023-09-01T10:38:16.464703Z-21654.txt (which were renamed in e0ca14b).

I don't see anything in the commits that explain why those files should be included in the repository. Personally, I'd be inclined to delete them.

The rest of the items appear normal and can be accepted as is.

@jsoref jsoref mentioned this pull request Mar 4, 2024
@Nishchit14
Copy link
Contributor Author

Thank you @jsoref for the PR with fixes, Those empty files were generated with Tauri initialisation process.

Also where can I see all these error logs? I tried to debug the failed job but I couldn't find anything helpful

@jsoref
Copy link
Contributor

jsoref commented Mar 4, 2024

For a given commit, you can click the ❌ on the right (a similar one at the bottom of a PR would work, but it's now a ✅ , so I can't link there):
image
And then click Details:
image
And then click Summary on the left:
image
Then scroll down to the bottom
image


The first bits are in:

Unrecognized words (4)

APPIMAGE
eciesjs
rustc
togglefullscreen


The second set of things were covered in this:

Some files were automatically ignored 🙈

These sample patterns would exclude them:

^\Qpackages/firecamp-tauri/src-tauri/rustc-ice-2023-08-29T12:21:32.539513Z-24344.txt\E$
^\Qpackages/firecamp-tauri/src-tauri/rustc-ice-2023-09-01T10:38:16.464703Z-21654.txt\E$

You should consider adding them to:

.github/actions/spelling/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.


And indication about forbidden patterns is in the Errors section:

Errors (3)

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

❌ Errors Count
ℹ️ binary-file 2
❌ check-file-path 2
❌ forbidden-pattern 2

See ❌ Event descriptions for more information.


The specific details of everything are in:

Details 🔎

...

@Nishchit14
Copy link
Contributor Author

Thank you @jsoref for your all help 🙌

@Nishchit14 Nishchit14 merged commit 21e36f6 into main Mar 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: The Desktop Application
3 participants