Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx: Improve GitHub OAuth redirect flow #145

Closed
Nishchit14 opened this issue Nov 6, 2023 · 0 comments
Closed

dx: Improve GitHub OAuth redirect flow #145

Nishchit14 opened this issue Nov 6, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Nishchit14
Copy link
Contributor

Description

The current GitHub OAuth redirect URL used after login is https://firecamp.dev/identity.html. This requires having a special identity.html page just for handling the redirect.

Instead, we could simplify the flow by redirecting directly to the main / route after login. This would allow removing the identity.html page and associated handler code.

Steps to implement:

  • Update GitHub OAuth config to set redirect URL to https://firecamp.dev/ rather than the identity page
  • Remove the identity.html page and routing code that points to it
  • Update main / route handler to check for authorization code in URL query params
  • If auth code is present, exchange it for a token and store it before redirecting to the actual / route
  • Modify other parts of the app that link to identity.html to point to / instead

This would clean up the auth flow and reduce redundant code.

@Nishchit14 Nishchit14 self-assigned this Nov 6, 2023
@Nishchit14 Nishchit14 added the enhancement New feature or request label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant