Repository navigation
chore(fork): carry the v2-transcript-cache and sqlite-reader-pool patches - #111
Merged
Merged
Conversation
…ches Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fireboltdude1357
left a comment
Owner
Author
There was a problem hiding this comment.
Manual review round 1: crev (claude-opus-5-5 + gpt-6.1-sol) (tier 7/10, deep review)
1 verified finding: 0 critical, 1 major, 0 minor. 1 posted inline, best first; 0 below.
Reviewed 1 files (+2 -0), 43c7bebe..2c3d2db7 against origin/patch/release.
| Severity | Location | Finding | Raised by | Evidence |
|---|---|---|---|---|
| major | .github/fork-patches.txt:12-13 |
Land both fixes before enabling their patch branches | 1 finder, one model | L3 |
Tier 7/10 from claude-opus-5-5: Build config line pulls whole patch branches (sqlite reader pool scheduling, transcript caching) into every nightly fork build; failures may not show up right away
Complexity low: Two config lines in a patch list; the complex logic lives in separately reviewed PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork builds don't carry the fixes for threads stuck on "Syncing messages..." while agents run. Both fixes sit on their own patch branches. This adds those branches to
.github/fork-patches.txtso the nightly build merges them:patch/v2-transcript-cachefollows fix(server): cache absent legacy transcripts for V2 threads pingdotgg/t3code#24707 (fork PR fix(server): opening a v2 thread stops re-checking its legacy transcript #107). Opening a thread created in v2 stops re-checking its legacy transcript.patch/sqlite-reader-poolfollows fix(shared): let SQLite reads proceed beside slow reads pingdotgg/t3code#24762 (fork PR fix(shared): thread opens stop waiting behind every other SQLite read #110). The pool of four readers, with reads admitted in the order they asked.Merge #107 and #110 first, so the build picks up the reviewed patches. The build was also failing on upstream conflicts in two existing patches; #108 and #109 fix those, and they need to merge before the next build passes.
Verification. In a scratch worktree at upstream
0b0417a, the patch list as it will be merged cleanly in order (releasefrom #108,cache-compactionfrom #109, then the existing patches, then these two). On the merged tree the build's checks pass:pnpm install --no-frozen-lockfile --fix-lockfile: done.vp run typecheck: 35 of 35 tasks pass.Review tier: 7/10; once this merges, the nightly build pulls in whatever is on these patch branches, which changes how every server read is scheduled
Two-way door: removing the lines drops the patches from the next build
Blast radius: which patches the fork nightly merges
Changes made by Claude Opus 5.5 in Claude Code, running in T3 Code.
🤖 Generated with Claude Code