-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(remote_config)!: check value types before passing them to native #6817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
536b7ee to
130cd58
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
2f713ec to
862b23a
Compare
|
Visit the preview URL for this PR (updated for commit 2f713ec): https://flutter-firebase-docs--pr6817-lesnitsky-check-def-yeldtgzu.web.app (expires Wed, 01 Sep 2021 10:56:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
BREAKING CHANGE: #setDefaults now throws if non-primitive value is being passed. We're being explicit about value types to prevent serialization of complex objects on native side, making them non-deserializable
637617f to
eeaab8a
Compare
russellwheatley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
packages/firebase_remote_config/firebase_remote_config/lib/src/remote_config.dart
Outdated
Show resolved
Hide resolved
packages/firebase_remote_config/firebase_remote_config/lib/src/remote_config.dart
Show resolved
Hide resolved
cabljac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
packages/firebase_remote_config/firebase_remote_config/lib/src/remote_config.dart
Show resolved
Hide resolved
|
@rrousselGit do you mind checking this one again? 8288352 |
|
LGTM |
Description
Check default value types and forbid anything other than primitives (booleans, numbers, strings)
Related Issues
Closes #2074
Closes #6074
Checklist
///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?