Skip to content

Conversation

@lesnitsky
Copy link
Member

@lesnitsky lesnitsky commented Aug 13, 2021

Description

Check default value types and forbid anything other than primitives (booleans, numbers, strings)

Related Issues

Closes #2074
Closes #6074

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Aug 13, 2021
@lesnitsky lesnitsky force-pushed the @lesnitsky/check_default_value_types branch from 536b7ee to 130cd58 Compare August 13, 2021 11:57
@google-cla
Copy link

google-cla bot commented Aug 25, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Aug 25, 2021
@lesnitsky lesnitsky force-pushed the @lesnitsky/check_default_value_types branch from 2f713ec to 862b23a Compare August 25, 2021 10:56
@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 25, 2021
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 2f713ec):

https://flutter-firebase-docs--pr6817-lesnitsky-check-def-yeldtgzu.web.app

(expires Wed, 01 Sep 2021 10:56:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@lesnitsky lesnitsky marked this pull request as ready for review August 25, 2021 11:00
@lesnitsky lesnitsky force-pushed the @lesnitsky/check_default_value_types branch from 637617f to eeaab8a Compare August 25, 2021 11:05
@lesnitsky lesnitsky changed the title chore(remote_config): check value types before passing them to native fix(remote_config)!: check value types before passing them to native Aug 25, 2021
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lesnitsky
Copy link
Member Author

@rrousselGit do you mind checking this one again? 8288352

@rrousselGit
Copy link
Contributor

LGTM

@lesnitsky lesnitsky merged commit db0afdb into master Sep 2, 2021
@lesnitsky lesnitsky deleted the @lesnitsky/check_default_value_types branch September 2, 2021 11:16
@firebase firebase locked and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

4 participants