Commit db0afdb
authored
fix(remote_config)!: check value types before passing them to native (#6817)
* fix(remote_config)!: check value types before passing them to native
BREAKING CHANGE: #setDefaults now throws if non-primitive value is being passed.
We're being explicit about value types to prevent serialization of complex objects on native side, making them non-deserializable
* fix(remote_config): apply correct condition
* refactor(remote_config): concat exception message lines
* refactor(remote_config): move params check logic out of the meethod channel
* test(remote_config): verify #setDefaults checks for argument type
* doc(remote_config): being explicit about value types
* refactor(remote_config): throw ArgumentError with more verbose description1 parent dc86445 commit db0afdb
File tree
2 files changed
+21
-0
lines changed- packages/firebase_remote_config/firebase_remote_config
- lib/src
- test
2 files changed
+21
-0
lines changedLines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| 135 | + | |
135 | 136 | | |
| 137 | + | |
136 | 138 | | |
137 | 139 | | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
138 | 150 | | |
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
216 | 225 | | |
217 | 226 | | |
218 | 227 | | |
| |||
0 commit comments