Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_dynamic_links] Change the OnLinkError object to be a real exception #15

Merged
merged 4 commits into from
Aug 25, 2019
Merged

[firebase_dynamic_links] Change the OnLinkError object to be a real exception #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbcbbb5
Change OnLinkException to be an actual exception
mehmetf Aug 23, 2019
59c1936
Fix formatting
mehmetf Aug 23, 2019
fca2b81
Merge branch 'master' of github.com:FirebaseExtended/flutterfire into b3
mehmetf Aug 25, 2019
df878bf
Update changelog
mehmetf Aug 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/firebase_dynamic_links/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.5.0+2

* Change the OnLinkError object to be a real exception.

## 0.5.0+1

* Update documentation to reflect new repository location.
Expand Down
12 changes: 4 additions & 8 deletions packages/firebase_dynamic_links/lib/src/firebase_dynamic_links.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,8 @@ class PendingDynamicLinkDataIOS {
final String minimumVersion;
}

class OnLinkErrorException {
OnLinkErrorException._(this.code, this.message, this.details);

final String code;

final String message;

final dynamic details;
/// This object is returned by the handler when an error occurs.
class OnLinkErrorException extends PlatformException {
OnLinkErrorException._(String code, String message, dynamic details)
: super(code: code, message: message, details: details);
}
2 changes: 1 addition & 1 deletion packages/firebase_dynamic_links/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: firebase_dynamic_links
description: Flutter plugin for Google Dynamic Links for Firebase, an app solution for creating
and handling links across multiple platforms.
version: 0.5.0+1
version: 0.5.0+2

author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_dynamic_links
Expand Down