Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[firebase_dynamic_links] Change the OnLinkError object to be a real exception #15

Merged
merged 4 commits into from
Aug 25, 2019
Merged

[firebase_dynamic_links] Change the OnLinkError object to be a real exception #15

merged 4 commits into from
Aug 25, 2019

Conversation

mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Aug 23, 2019

Firebase dynamic links creates a new error object. This should extend PlatformException (it effectively carries the same signature) so that it can be thrown by the app if needed.

@mehmetf
Copy link
Contributor Author

mehmetf commented Aug 23, 2019

This fixes #6

@collinjackson collinjackson self-requested a review August 23, 2019 22:25
@collinjackson
Copy link
Contributor

collinjackson commented Aug 23, 2019 •
edited
Loading

LGTM once bots are happy and changelog included.

Aside: We don't seem to be unit testing onLink, which seems like an omission, but I don't think it needs to hold back this change.

@mehmetf mehmetf requested a review from bparrishMines as a code owner August 25, 2019 12:57
@mehmetf mehmetf merged commit 58b956f into firebase:master Aug 25, 2019
@mehmetf mehmetf deleted the b3 branch August 25, 2019 13:34
@mehmetf mehmetf mentioned this pull request Aug 25, 2019
Closed
@urbanjagodic urbanjagodic mentioned this pull request Sep 9, 2019
Closed
@YonatanAmitzur YonatanAmitzur mentioned this pull request Sep 16, 2019
Closed
@caseyryan caseyryan mentioned this pull request Oct 2, 2019
Closed
@pinkeshAubergine pinkeshAubergine mentioned this pull request Oct 9, 2019
Closed
@kroikie kroikie mentioned this pull request Oct 13, 2019
Closed
@exilonX exilonX mentioned this pull request Oct 16, 2019
Closed
@kroikie kroikie mentioned this pull request Oct 21, 2019
Closed
@agnoam agnoam mentioned this pull request Oct 23, 2019
Closed
@Parmendrakumar Parmendrakumar mentioned this pull request Nov 5, 2019
Closed
@PrismaSoftGC PrismaSoftGC mentioned this pull request Nov 5, 2019
Closed
@IvanOnishchenko IvanOnishchenko mentioned this pull request Nov 6, 2019
Closed
@habtish1 habtish1 mentioned this pull request Nov 7, 2019
Closed
@Sonderman Sonderman mentioned this pull request Nov 18, 2019
Closed
@amitverma-cf amitverma-cf mentioned this pull request Nov 18, 2019
Closed
@boylenssen boylenssen mentioned this pull request Nov 20, 2019
Closed
@fabianogadenz fabianogadenz mentioned this pull request Nov 20, 2019
Closed
@emailsubjekt emailsubjekt mentioned this pull request Dec 9, 2019
Closed
@NickM-27 NickM-27 mentioned this pull request Dec 12, 2019
Closed
@YohanWadia YohanWadia mentioned this pull request Apr 3, 2020
Closed
@aliheader aliheader mentioned this pull request Apr 3, 2020
Closed
@adworzynski adworzynski mentioned this pull request Apr 15, 2020
Closed
@vineetpandit90 vineetpandit90 mentioned this pull request Apr 17, 2020
Closed
@ishtms ishtms mentioned this pull request Apr 17, 2020
Closed
@HEMANT96 HEMANT96 mentioned this pull request Apr 22, 2020
Closed
@zameerhossain zameerhossain mentioned this pull request Apr 28, 2020
Closed
@YashMobileFirst YashMobileFirst mentioned this pull request Apr 28, 2020
Closed
@navigui navigui mentioned this pull request Apr 30, 2020
Closed
@besidesordinary besidesordinary mentioned this pull request May 5, 2020
Closed
@sunilcoder36 sunilcoder36 mentioned this pull request May 6, 2020
Closed
@Niccolohui Niccolohui mentioned this pull request May 8, 2020
Closed
@clus90 clus90 mentioned this pull request May 8, 2020
Closed
@ADTheJava ADTheJava mentioned this pull request May 11, 2020
Closed
@hashika2 hashika2 mentioned this pull request May 22, 2020
Closed
@DyaryRaoof DyaryRaoof mentioned this pull request May 27, 2020
Closed
@momo1606 momo1606 mentioned this pull request Jun 2, 2020
Closed
@aislingorg aislingorg mentioned this pull request Jun 3, 2020
Closed
@MassiveSuccess MassiveSuccess mentioned this pull request Jun 7, 2020
Closed
@kartikpateldev kartikpateldev mentioned this pull request Jun 8, 2020
Closed
@bytejutsu bytejutsu mentioned this pull request Jun 12, 2020
Closed
@CarltonK CarltonK mentioned this pull request Jun 14, 2020
Closed
@Saraalr Saraalr mentioned this pull request Jun 26, 2020
Closed
@braysonjohn148 braysonjohn148 mentioned this pull request Jun 26, 2020
Closed
@sumanthkumarps sumanthkumarps mentioned this pull request Jul 5, 2020
Closed
@lukaszciastko lukaszciastko mentioned this pull request Jul 11, 2020
Closed
@hitanshu1 hitanshu1 mentioned this pull request Aug 12, 2020
Closed
@giorodri0584 giorodri0584 mentioned this pull request Aug 12, 2020
Closed
@itssidhere itssidhere mentioned this pull request Aug 18, 2020
Closed
@firebase firebase locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collinjackson collinjackson collinjackson approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehmetf @collinjackson