Skip to content

Upgrade to pg17 #9617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joehan wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −1
Open

Upgrade to pg17 #9617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d64d83
Upgrade to pg17
joehan Dec 12, 2025
6c91847
changelog
joehan Dec 12, 2025
aa3b446
Merge branch 'main' into jh-pg17
joehan Dec 13, 2025
b9f989e
Merge branch 'main' into jh-pg17
joehan Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Updated default Postgres version for Data Connect to 17.
2 changes: 1 addition & 1 deletion src/gcp/cloudsql/cloudsqladmin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export function instanceConsoleLink(projectId: string, instanceId: string) {
}

export type DataConnectLabel = "ft" | "nt";
export const DEFAULT_DATABASE_VERSION = "POSTGRES_15";
export const DEFAULT_DATABASE_VERSION = "POSTGRES_17";
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While changing the default version to POSTGRES_17 is the goal of this PR, the tests for createInstance in cloudsqladmin.spec.ts don't verify the request body. This means this change is not covered by automated tests. To improve maintainability and prevent potential regressions, I recommend enhancing the tests to assert that the databaseVersion in the API call payload matches this constant.


export async function createInstance(args: {
projectId: string;
Expand Down
Loading