Upgrade to pg17

[joehan]

Description

Change default PG version to 17.

Scenarios Tested

Deployed a new DB onto a project with billing set up

[gemini-code-assist]

Summary of Changes

Hello @joehan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the system's default PostgreSQL version to 17, ensuring that new database deployments leverage the latest stable release. This change aims to provide access to new features, performance improvements, and security enhancements offered by PostgreSQL 17, with testing confirming successful deployment in a billing-enabled project.

Highlights

• Default PostgreSQL Version: The default PostgreSQL database version used for new deployments has been updated from "POSTGRES_15" to "POSTGRES_17".

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the default PostgreSQL version for new Cloud SQL instances from 15 to 17. The change itself is straightforward and appears correct. My review includes one suggestion to improve the test coverage for this change to increase the robustness of the codebase and prevent future regressions.

[gemini-code-assist]

While changing the default version to POSTGRES_17 is the goal of this PR, the tests for createInstance in cloudsqladmin.spec.ts don't verify the request body. This means this change is not covered by automated tests. To improve maintainability and prevent potential regressions, I recommend enhancing the tests to assert that the databaseVersion in the API call payload matches this constant.