Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing BlockReason and FinishReason enum values #8741

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add missing BlockReason and FinishReason enum values #8741

wants to merge 3 commits into from
+44 −2

Conversation

dlarocque
Copy link
Contributor

Add the enum values that are missing from BlockReason and FinishReason.

b/393142020 (internal)

@dlarocque dlarocque requested review from a team as code owners January 30, 2025 16:09
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3bb9992

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/vertexai Minor
firebase Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 30, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (01f36ea)Merge (b109f27)Diff
    browser29.0 kB29.3 kB+280 B (+1.0%)
    main29.9 kB30.1 kB+280 B (+0.9%)
    module29.0 kB29.3 kB+280 B (+1.0%)

  • firebase

    TypeBase (01f36ea)Merge (b109f27)Diff
    firebase-vertexai.js24.0 kB24.2 kB+198 B (+0.8%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xtlLYp6Ibu.html

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v6.1

@dlarocque dlarocque requested a review from hsubox76 January 30, 2025 20:27
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 30, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • ArraySchema

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size4.61 kB4.83 kB+216 B (+4.7%)
      size-with-ext-deps22.5 kB22.7 kB+216 B (+1.0%)

    • BlockReason

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size2.52 kB2.74 kB+216 B (+8.6%)
      size-with-ext-deps20.4 kB20.6 kB+216 B (+1.1%)

    • BooleanSchema

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size4.61 kB4.83 kB+216 B (+4.7%)
      size-with-ext-deps22.5 kB22.7 kB+216 B (+1.0%)

    • ChatSession

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size14.6 kB14.8 kB+216 B (+1.5%)
      size-with-ext-deps33.2 kB33.4 kB+216 B (+0.7%)

    • FinishReason

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size2.52 kB2.74 kB+216 B (+8.6%)
      size-with-ext-deps20.4 kB20.6 kB+216 B (+1.1%)

    • FunctionCallingMode

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size2.53 kB2.74 kB+216 B (+8.5%)
      size-with-ext-deps20.4 kB20.6 kB+216 B (+1.1%)

    • GenerativeModel

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size17.3 kB17.5 kB+216 B (+1.2%)
      size-with-ext-deps36.0 kB36.2 kB+216 B (+0.6%)

    • HarmBlockMethod

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size2.52 kB2.74 kB+216 B (+8.6%)
      size-with-ext-deps20.4 kB20.6 kB+216 B (+1.1%)

    • HarmBlockThreshold

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size2.53 kB2.74 kB+216 B (+8.5%)
      size-with-ext-deps20.4 kB20.6 kB+216 B (+1.1%)

    • HarmCategory

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size2.52 kB2.74 kB+216 B (+8.6%)
      size-with-ext-deps20.4 kB20.6 kB+216 B (+1.1%)

    • HarmProbability

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size2.52 kB2.74 kB+216 B (+8.6%)
      size-with-ext-deps20.4 kB20.6 kB+216 B (+1.1%)

    • HarmSeverity

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size2.52 kB2.74 kB+216 B (+8.6%)
      size-with-ext-deps20.4 kB20.6 kB+216 B (+1.1%)

    • IntegerSchema

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size4.61 kB4.83 kB+216 B (+4.7%)
      size-with-ext-deps22.5 kB22.7 kB+216 B (+1.0%)

    • NumberSchema

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size4.61 kB4.83 kB+216 B (+4.7%)
      size-with-ext-deps22.5 kB22.7 kB+216 B (+1.0%)

    • ObjectSchema

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size4.61 kB4.83 kB+216 B (+4.7%)
      size-with-ext-deps22.5 kB22.7 kB+216 B (+1.0%)

    • POSSIBLE_ROLES

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size2.57 kB2.78 kB+216 B (+8.4%)
      size-with-ext-deps20.5 kB20.7 kB+216 B (+1.1%)

    • Schema

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size4.61 kB4.82 kB+216 B (+4.7%)
      size-with-ext-deps22.5 kB22.7 kB+216 B (+1.0%)

    • SchemaType

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size2.52 kB2.74 kB+216 B (+8.6%)
      size-with-ext-deps20.4 kB20.6 kB+216 B (+1.1%)

    • StringSchema

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size4.61 kB4.83 kB+216 B (+4.7%)
      size-with-ext-deps22.5 kB22.7 kB+216 B (+1.0%)

    • VertexAIError

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size2.83 kB3.04 kB+216 B (+7.6%)
      size-with-ext-deps20.7 kB20.9 kB+216 B (+1.0%)

    • getGenerativeModel

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size17.5 kB17.7 kB+216 B (+1.2%)
      size-with-ext-deps36.1 kB36.3 kB+216 B (+0.6%)

    • getVertexAI

      Size

      TypeBase (01f36ea)Merge (b109f27)Diff
      size2.70 kB2.92 kB+216 B (+8.0%)
      size-with-ext-deps27.9 kB28.1 kB+216 B (+0.8%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5hOR06VbYh.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@rachelsaunders rachelsaunders Awaiting requested review from rachelsaunders

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlarocque @google-oss-bot @hsubox76