Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create VertexAI Node CJS and ESM bundles #8728

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Create VertexAI Node CJS and ESM bundles #8728

merged 4 commits into from
Feb 18, 2025

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Jan 24, 2025 •
edited
Loading

Create a new Node entrypoint index.node.ts where we can make Node-specific modifications to the bundles. This will be required for upcoming features where Node and Web bundles use different libraries.

go/firebase-js-sdk-vertex-node-bundle (internal)

@dlarocque dlarocque requested a review from hsubox76 January 24, 2025 15:58
@dlarocque dlarocque requested a review from a team as a code owner January 24, 2025 15:58
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: b56a6b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/vertexai Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dlarocque dlarocque requested a review from DellaBitta January 24, 2025 15:58
@dlarocque dlarocque requested review from a team as code owners January 24, 2025 16:01
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (178ad99)Merge (632807a)Diff
    browser19.2 kB19.5 kB+276 B (+1.4%)
    main20.1 kB20.4 kB+276 B (+1.4%)
    module19.2 kB19.5 kB+276 B (+1.4%)

  • @firebase/auth

    TypeBase (178ad99)Merge (632807a)Diff
    browser188 kB189 kB+750 B (+0.4%)
    cordova164 kB164 kB+750 B (+0.5%)
    main145 kB146 kB+760 B (+0.5%)
    module188 kB189 kB+750 B (+0.4%)
    react-native163 kB164 kB+760 B (+0.5%)

  • @firebase/auth-cordova

    TypeBase (178ad99)Merge (632807a)Diff
    browser164 kB164 kB+750 B (+0.5%)
    module164 kB164 kB+750 B (+0.5%)

  • @firebase/auth-web-extension

    TypeBase (178ad99)Merge (632807a)Diff
    browser140 kB141 kB+750 B (+0.5%)
    main157 kB158 kB+764 B (+0.5%)
    module140 kB141 kB+750 B (+0.5%)

  • @firebase/auth/internal

    TypeBase (178ad99)Merge (632807a)Diff
    browser199 kB200 kB+750 B (+0.4%)
    main171 kB172 kB+768 B (+0.4%)
    module199 kB200 kB+750 B (+0.4%)

  • @firebase/data-connect

    TypeBase (178ad99)Merge (632807a)Diff
    browser20.3 kB21.1 kB+835 B (+4.1%)
    main22.2 kB23.1 kB+933 B (+4.2%)
    module20.3 kB21.1 kB+835 B (+4.1%)

  • @firebase/database

    TypeBase (178ad99)Merge (632807a)Diff
    browser249 kB249 kB+312 B (+0.1%)
    main254 kB254 kB+307 B (+0.1%)
    module249 kB249 kB+312 B (+0.1%)

  • @firebase/database-compat/standalone

    TypeBase (178ad99)Merge (632807a)Diff
    main365 kB366 kB+695 B (+0.2%)

  • @firebase/firestore

    TypeBase (178ad99)Merge (632807a)Diff
    browser380 kB380 kB+246 B (+0.1%)
    main589 kB589 kB+343 B (+0.1%)
    module380 kB380 kB+246 B (+0.1%)
    react-native380 kB381 kB+246 B (+0.1%)

  • @firebase/firestore-lite

    TypeBase (178ad99)Merge (632807a)Diff
    browser112 kB112 kB+246 B (+0.2%)
    main154 kB154 kB+342 B (+0.2%)
    module112 kB112 kB+246 B (+0.2%)
    react-native112 kB112 kB+246 B (+0.2%)

  • @firebase/performance

    TypeBase (178ad99)Merge (632807a)Diff
    browser30.6 kB30.6 kB-1 B (-0.0%)
    main31.1 kB31.1 kB-1 B (-0.0%)
    module30.6 kB30.6 kB-1 B (-0.0%)

  • @firebase/remote-config

    TypeBase (178ad99)Merge (632807a)Diff
    browser21.7 kB23.2 kB+1.51 kB (+7.0%)
    main22.9 kB24.4 kB+1.51 kB (+6.6%)
    module21.7 kB23.2 kB+1.51 kB (+7.0%)

  • @firebase/vertexai

    TypeBase (178ad99)Merge (632807a)Diff
    browser29.0 kB29.2 kB+196 B (+0.7%)
    main29.9 kB30.0 kB+196 B (+0.7%)
    module29.0 kB29.2 kB+196 B (+0.7%)

  • bundle

    46 size changes

    TypeBase (178ad99)Merge (632807a)Diff
    analytics (logEvent)44.6 kB44.7 kB+109 B (+0.2%)
    app-check (CustomProvider)37.3 kB37.4 kB+109 B (+0.3%)
    app-check (ReCaptchaEnterpriseProvider)39.8 kB39.9 kB+109 B (+0.3%)
    app-check (ReCaptchaV3Provider)39.8 kB39.9 kB+109 B (+0.3%)
    auth (Anonymous)76.4 kB76.6 kB+256 B (+0.3%)
    auth (EmailAndPassword)86.5 kB86.8 kB+256 B (+0.3%)
    auth (GoogleFBTwitterGitHubPopup)103 kB104 kB+401 B (+0.4%)
    auth (GooglePopup)100 kB101 kB+256 B (+0.3%)
    auth (GoogleRedirect)101 kB101 kB+256 B (+0.3%)
    auth (Phone)93.9 kB94.2 kB+256 B (+0.3%)
    database (Append to a list of data)149 kB150 kB+293 B (+0.2%)
    database (Filtering data)148 kB149 kB+293 B (+0.2%)
    database (Listen for child events)165 kB165 kB+293 B (+0.2%)
    database (Listen for value events + Detach listeners)165 kB165 kB+293 B (+0.2%)
    database (Listen for value events)165 kB165 kB+293 B (+0.2%)
    database (Read data once)164 kB164 kB+293 B (+0.2%)
    database (Save data as transactions)167 kB167 kB+293 B (+0.2%)
    database (Sort data)150 kB150 kB+293 B (+0.2%)
    database (Write data)149 kB149 kB+293 B (+0.2%)
    firestore (CSI Auto Indexing Disable and Delete)271 kB271 kB+347 B (+0.1%)
    firestore (CSI Auto Indexing Enable)271 kB271 kB+347 B (+0.1%)
    firestore (Persistence)302 kB303 kB+347 B (+0.1%)
    firestore (Query Cursors)249 kB250 kB+347 B (+0.1%)
    firestore (Query)247 kB247 kB+347 B (+0.1%)
    firestore (Read data once)235 kB235 kB+347 B (+0.1%)
    firestore (Read Write w Persistence)327 kB327 kB+347 B (+0.1%)
    firestore (Realtime updates)237 kB237 kB+347 B (+0.1%)
    firestore (Transaction)214 kB214 kB+347 B (+0.2%)
    firestore (Write data)214 kB214 kB+347 B (+0.2%)
    firestore-lite (Query Cursors)103 kB103 kB+347 B (+0.3%)
    firestore-lite (Query)99.1 kB99.4 kB+347 B (+0.4%)
    firestore-lite (Read data once)74.5 kB74.9 kB+347 B (+0.5%)
    firestore-lite (Transaction)99.8 kB100 kB+347 B (+0.3%)
    firestore-lite (Write data)84.1 kB84.5 kB+347 B (+0.4%)
    functions (call)34.7 kB34.8 kB+107 B (+0.3%)
    messaging (send + receive)47.4 kB47.5 kB+109 B (+0.2%)
    performance (trace)62.3 kB62.4 kB+108 B (+0.2%)
    remote-config (getAndFetch)47.5 kB48.8 kB+1.24 kB (+2.6%)
    storage (getBytes)42.3 kB42.4 kB+109 B (+0.3%)
    storage (getDownloadURL)44.4 kB44.5 kB+109 B (+0.2%)
    storage (getMetadata)43.8 kB43.9 kB+109 B (+0.2%)
    storage (list + listAll)43.2 kB43.3 kB+109 B (+0.3%)
    storage (updateMetadata)44.1 kB44.2 kB+109 B (+0.2%)
    storage (uploadBytes)48.9 kB49.0 kB+109 B (+0.2%)
    storage (uploadBytesResumable)58.9 kB59.0 kB+109 B (+0.2%)
    storage (uploadString)49.1 kB49.3 kB+109 B (+0.2%)

  • firebase

    25 size changes

    TypeBase (178ad99)Merge (632807a)Diff
    firebase-analytics-compat.js26.5 kB25.7 kB-795 B (-3.0%)
    firebase-app-check-compat.js23.2 kB22.6 kB-615 B (-2.6%)
    firebase-app-compat.js32.3 kB31.8 kB-587 B (-1.8%)
    firebase-app.js102 kB103 kB+706 B (+0.7%)
    firebase-auth-compat.js143 kB140 kB-2.94 kB (-2.1%)
    firebase-auth-cordova.js136 kB137 kB+598 B (+0.4%)
    firebase-auth-web-extension.js119 kB119 kB+598 B (+0.5%)
    firebase-auth.js155 kB155 kB+598 B (+0.4%)
    firebase-compat.js808 kB792 kB-15.9 kB (-2.0%)
    firebase-data-connect.js16.8 kB17.3 kB+554 B (+3.3%)
    firebase-database-compat.js166 kB164 kB-2.40 kB (-1.4%)
    firebase-database.js187 kB187 kB+525 B (+0.3%)
    firebase-firestore-compat.js345 kB339 kB-6.35 kB (-1.8%)
    firebase-firestore-lite.js130 kB130 kB+246 B (+0.2%)
    firebase-firestore.js439 kB439 kB+246 B (+0.1%)
    firebase-functions-compat.js10.6 kB10.4 kB-254 B (-2.4%)
    firebase-installations-compat.js13.3 kB12.9 kB-384 B (-2.9%)
    firebase-messaging-compat.js38.7 kB37.0 kB-1.64 kB (-4.2%)
    firebase-performance-compat.js40.9 kB40.0 kB-869 B (-2.1%)
    firebase-performance-standalone-compat.js105 kB105 kB+113 B (+0.1%)
    firebase-performance.js45.5 kB45.5 kB-1 B (-0.0%)
    firebase-remote-config-compat.js28.4 kB28.3 kB-125 B (-0.4%)
    firebase-remote-config.js31.1 kB32.7 kB+1.54 kB (+4.9%)
    firebase-storage-compat.js40.4 kB39.7 kB-690 B (-1.7%)
    firebase-vertexai.js24.0 kB24.4 kB+433 B (+1.8%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WEPMymSVbH.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2025 •
edited
Loading

Size Analysis Report 1

This report is too large (341,404 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qX13FUDVHU.html

@dlarocque dlarocque requested a review from hsubox76 February 14, 2025 19:07
@dlarocque dlarocque merged commit 884cbd7 into main Feb 18, 2025
38 checks passed
@dlarocque dlarocque deleted the dl/vertex-node branch February 18, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@DellaBitta DellaBitta Awaiting requested review from DellaBitta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlarocque @google-oss-bot @hsubox76