Use logger class and send App Check dummy token in header #8591

hsubox76 · 2024-10-23T17:20:48Z

App Check's getToken() should never throw, but in case of an error getting a valid App Check token, it fills in the "token" field with a standard dummy token, and adds an "error" field. The backend needs to receive these dummy tokens in the header so the developer can track failed requests. Right now we just don't send them. This change sends the dummy token, and logs a warning if an error is found.

I also realized I forgot to include the standard logger API in VertexAI so I added it. This is a wrapper around console used across all products that adds a product name prefix and also enables the global setLogLevel() to apply to any console messages called through this wrapper.

changeset-bot · 2024-10-23T17:20:52Z

🦋 Changeset detected

Latest commit: 9e8ef56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@firebase/vertexai	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2024-10-23T17:49:09Z

Size Analysis Report ¹

Affected Products

`@firebase/vertexai`

ArraySchema
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 4.54 kB 4.61 kB +70 B (+1.5%)
size-with-ext-deps 22.4 kB 22.4 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
BlockReason
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 2.45 kB 2.52 kB +70 B (+2.9%)
size-with-ext-deps 20.3 kB 20.3 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
BooleanSchema
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 4.54 kB 4.61 kB +70 B (+1.5%)
size-with-ext-deps 22.4 kB 22.4 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger

`ChatSession`

Size

Type	Base (`1f1ba3f`)	Merge (`109f9be`)	Diff
size	14.5 kB	14.7 kB	+127 B (+0.9%)
size-with-ext-deps	33.1 kB	33.2 kB	+87 B (+0.3%)

Dependency

Type Base (1f1ba3f) Merge (109f9be) Diff

variables

25 dependencies

BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
SchemaType
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

26 dependencies

BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
SchemaType
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
logger
name
responseLineRE
version

+ logger

External Dependency

Module	Base (`1f1ba3f`)	Merge (`109f9be`)	Diff
`@firebase/logger`		Logger	+ Logger

FinishReason
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 2.45 kB 2.52 kB +70 B (+2.9%)
size-with-ext-deps 20.3 kB 20.3 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
FunctionCallingMode
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 2.46 kB 2.53 kB +70 B (+2.8%)
size-with-ext-deps 20.3 kB 20.3 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger

`GenerativeModel`

Size

Type	Base (`1f1ba3f`)	Merge (`109f9be`)	Diff
size	17.0 kB	17.2 kB	+127 B (+0.7%)
size-with-ext-deps	35.6 kB	35.7 kB	+87 B (+0.2%)

Dependency

Type Base (1f1ba3f) Merge (109f9be) Diff

variables

25 dependencies

BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
SchemaType
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

26 dependencies

BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
SchemaType
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
logger
name
responseLineRE
version

+ logger

External Dependency

Module	Base (`1f1ba3f`)	Merge (`109f9be`)	Diff
`@firebase/logger`		Logger	+ Logger

HarmBlockMethod
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 2.45 kB 2.52 kB +70 B (+2.9%)
size-with-ext-deps 20.3 kB 20.3 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
HarmBlockThreshold
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 2.46 kB 2.53 kB +70 B (+2.8%)
size-with-ext-deps 20.3 kB 20.3 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
HarmCategory
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 2.45 kB 2.52 kB +70 B (+2.9%)
size-with-ext-deps 20.3 kB 20.3 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
HarmProbability
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 2.45 kB 2.52 kB +70 B (+2.9%)
size-with-ext-deps 20.3 kB 20.3 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
HarmSeverity
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 2.45 kB 2.52 kB +70 B (+2.9%)
size-with-ext-deps 20.3 kB 20.3 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
IntegerSchema
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 4.54 kB 4.61 kB +70 B (+1.5%)
size-with-ext-deps 22.4 kB 22.4 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
NumberSchema
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 4.54 kB 4.61 kB +70 B (+1.5%)
size-with-ext-deps 22.4 kB 22.4 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
ObjectSchema
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 4.54 kB 4.61 kB +70 B (+1.5%)
size-with-ext-deps 22.4 kB 22.4 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
POSSIBLE_ROLES
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 2.50 kB 2.57 kB +70 B (+2.8%)
size-with-ext-deps 20.3 kB 20.4 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
Schema
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 4.54 kB 4.61 kB +70 B (+1.5%)
size-with-ext-deps 22.4 kB 22.4 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
SchemaType
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 2.45 kB 2.52 kB +70 B (+2.9%)
size-with-ext-deps 20.3 kB 20.3 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
StringSchema
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 4.54 kB 4.61 kB +70 B (+1.5%)
size-with-ext-deps 22.4 kB 22.4 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger
VertexAIError
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 2.76 kB 2.83 kB +70 B (+2.5%)
size-with-ext-deps 20.6 kB 20.6 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger

`getGenerativeModel`

Size

Type	Base (`1f1ba3f`)	Merge (`109f9be`)	Diff
size	17.2 kB	17.3 kB	+127 B (+0.7%)
size-with-ext-deps	35.7 kB	35.8 kB	+87 B (+0.2%)

Dependency

Type Base (1f1ba3f) Merge (109f9be) Diff

variables

25 dependencies

BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
SchemaType
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

26 dependencies

BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
FinishReason
FunctionCallingMode
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
SchemaType
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
logger
name
responseLineRE
version

+ logger

External Dependency

Module	Base (`1f1ba3f`)	Merge (`109f9be`)	Diff
`@firebase/logger`		Logger	+ Logger

getVertexAI
Size
Type Base (1f1ba3f) Merge (109f9be) Diff
size 2.63 kB 2.70 kB +70 B (+2.7%)
size-with-ext-deps 27.8 kB 27.8 kB +28 B (+0.1%)
External Dependency
Module Base (1f1ba3f) Merge (109f9be) Diff
@firebase/logger
Logger
+ Logger

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/UBv7ZDZUTI.html

DellaBitta

Looks like you can drop the base64 import.

google-oss-bot · 2024-10-23T20:32:29Z

Size Report ¹

Affected Products

@firebase/vertexai
Type Base (1f1ba3f) Merge (109f9be) Diff
browser 28.7 kB 28.9 kB +169 B (+0.6%)
main 29.5 kB 29.7 kB +206 B (+0.7%)
module 28.7 kB 28.9 kB +169 B (+0.6%)
firebase
Type Base (1f1ba3f) Merge (109f9be) Diff
firebase-vertexai.js 22.1 kB 23.9 kB +1.79 kB (+8.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/XlkrP2gxLe.html

hsubox76 · 2024-10-23T21:10:21Z

Looks like you can drop the base64 import.

Thanks, got it.

Use logger class and send App Check dummy token in header.

96c65a2

hsubox76 marked this pull request as ready for review October 23, 2024 17:21

hsubox76 requested review from a team as code owners October 23, 2024 17:21

DellaBitta approved these changes Oct 23, 2024

View reviewed changes

Remove extra import

9e8ef56

hsubox76 merged commit 4db3d3e into main Oct 23, 2024
38 of 39 checks passed

hsubox76 deleted the ch-appcheck-token-fix branch October 23, 2024 21:12

google-oss-bot mentioned this pull request Nov 12, 2024

Version Packages #8635

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use logger class and send App Check dummy token in header #8591

Use logger class and send App Check dummy token in header #8591

hsubox76 commented Oct 23, 2024

changeset-bot bot commented Oct 23, 2024 •

edited

Loading

google-oss-bot commented Oct 23, 2024 •

edited

Loading

`@firebase/vertexai`

`ArraySchema`

`BlockReason`

`BooleanSchema`

`ChatSession`

`FinishReason`

`FunctionCallingMode`

`GenerativeModel`

`HarmBlockMethod`

`HarmBlockThreshold`

`HarmCategory`

`HarmProbability`

`HarmSeverity`

`IntegerSchema`

`NumberSchema`

`ObjectSchema`

`POSSIBLE_ROLES`

`Schema`

`SchemaType`

`StringSchema`

`VertexAIError`

`getGenerativeModel`

`getVertexAI`

DellaBitta left a comment

google-oss-bot commented Oct 23, 2024

`@firebase/vertexai`

`firebase`

hsubox76 commented Oct 23, 2024

Use logger class and send App Check dummy token in header #8591

Use logger class and send App Check dummy token in header #8591

Conversation

hsubox76 commented Oct 23, 2024

changeset-bot bot commented Oct 23, 2024 • edited Loading

🦋 Changeset detected

google-oss-bot commented Oct 23, 2024 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/vertexai

ArraySchema

BlockReason

BooleanSchema

ChatSession

FinishReason

FunctionCallingMode

GenerativeModel

HarmBlockMethod

HarmBlockThreshold

HarmCategory

HarmProbability

HarmSeverity

IntegerSchema

NumberSchema

ObjectSchema

POSSIBLE_ROLES

Schema

SchemaType

StringSchema

VertexAIError

getGenerativeModel

getVertexAI

Test Logs

DellaBitta left a comment

Choose a reason for hiding this comment

google-oss-bot commented Oct 23, 2024

Size Report 1

Affected Products

@firebase/vertexai

firebase

Test Logs

hsubox76 commented Oct 23, 2024

changeset-bot bot commented Oct 23, 2024 •

edited

Loading

google-oss-bot commented Oct 23, 2024 •

edited

Loading

Size Analysis Report ¹

`@firebase/vertexai`

`ArraySchema`

`BlockReason`

`BooleanSchema`

`ChatSession`

`FinishReason`

`FunctionCallingMode`

`GenerativeModel`

`HarmBlockMethod`

`HarmBlockThreshold`

`HarmCategory`

`HarmProbability`

`HarmSeverity`

`IntegerSchema`

`NumberSchema`

`ObjectSchema`

`POSSIBLE_ROLES`

`Schema`

`SchemaType`

`StringSchema`

`VertexAIError`

`getGenerativeModel`

`getVertexAI`

Size Report ¹

`@firebase/vertexai`

`firebase`