Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workflows for forks #8275

Closed
wants to merge 19 commits into from
Closed

Fix workflows for forks #8275

wants to merge 19 commits into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented May 30, 2024

@jsoref jsoref requested a review from a team as a code owner May 30, 2024 13:44
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b35ab8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jsoref jsoref marked this pull request as draft May 30, 2024 14:38
@jsoref
Copy link
Contributor Author

jsoref commented May 30, 2024

Fwiw, I have a larger set of changes that would fix more of these -- but this small set is the first part that I trip on when using the repository...

jsoref added 18 commits May 30, 2024 19:03
@jsoref jsoref marked this pull request as ready for review May 30, 2024 23:05
@jsoref jsoref changed the title Look before leaping Fix workflows for forks May 30, 2024
This was referenced May 30, 2024
Merged
Merged
@jsoref
Use GitHub ref to get PR head
b35ab8e 
The pull request head ref name is local to its originating repository.
For pull requests from forks, that ref is unlikely to exist.

GitHub has special magic refs (refs/pull/<number>/<head|merge>) that can
be used to reference the pull request from the destination repository's
perspective.

Note that the merge magic ref is not instance and is slightly quirky.
Here, we're using the head ref which is less quirky.
@dlarocque
Copy link
Contributor

Hi @jsoref, this is great, thanks for the PR!

There are changes in here that we would certainly want to have (e.g. upgrading versions), but others would need some closer review by the team. To help us break down the review process, could you create seperate PRs for all of the distinct changes in this PR so that we can review them individually?

@jsoref
Copy link
Contributor Author

jsoref commented May 31, 2024

Sure

This was referenced May 31, 2024
Open
Open
Open
Open
Open
Open
@jsoref
Copy link
Contributor Author

jsoref commented May 31, 2024

That's the full split. My week is over. See you next week.

@dlarocque dlarocque closed this Jun 1, 2024
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoref @dlarocque