Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job to create a GitHub release #8248

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

dlarocque
Copy link
Contributor

Adds a job to the production release workflow to create a GitHub release.

I tested this on a minimal version (no build or npm publish) of the workflow on a fork. It adds and pushes tags the same way that the scripts/release/release.ts script does.
Test workflow: https://github.com/dlarocque/firebase-js-sdk/blob/master/.github/workflows/test-release.yml
Resulting release: https://github.com/dlarocque/firebase-js-sdk/releases/tag/firebase%405.5.5

This job assumes that the version packages PR was already merged.

@dlarocque dlarocque requested a review from hsubox76 May 14, 2024 20:30
@dlarocque dlarocque requested a review from a team as a code owner May 14, 2024 20:30
Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: 37ccc60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 14, 2024

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 14, 2024


# Get the release notes from the description of the most recent merged PR into the "release" branch
# See: https://github.com/firebase/firebase-js-sdk/pull/8236 for an example description
RELEASE_NOTES=$(gh pr list \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were we going to add in some text to say "For more detailed release notes, see Firebase JavaScript SDK Release Notes."? You might want to test if you have to escape any of those markdown linking characters.

Changesets are better than commits but I think release notes may have more info than changesets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
# Get the newest release tag for the firebase package (e.g. [email protected])
NEWEST_TAG=$(git describe --tags --match "firebase@[0-9]*.[0-9]*.[0-9]*" --abbrev=0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of --match to solve this problem.

@dlarocque dlarocque requested a review from hsubox76 May 16, 2024 14:34
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done! Can't wait to see if it works on the next prod release.

@dlarocque dlarocque merged commit 43a8d99 into master May 16, 2024
36 checks passed
@dlarocque dlarocque deleted the dlarocque/github-releases branch May 16, 2024 17:25
@firebase firebase locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants