Add job to create a GitHub release #8248
Conversation
|
Size Report 1Affected ProductsNo changes between base commit (f66769c) and merge commit (7f236c1).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (f66769c) and merge commit (7f236c1).Test Logs |
dlarocque
force-pushed
the
dlarocque/github-releases
branch
from
31e7834
to
b75cb32
Compare
.github/workflows/release-prod.yml
Outdated
|
|
||
| # Get the release notes from the description of the most recent merged PR into the "release" branch | ||
| # See: https://github.com/firebase/firebase-js-sdk/pull/8236 for an example description | ||
| RELEASE_NOTES=$(gh pr list \ |
There was a problem hiding this comment.
Were we going to add in some text to say "For more detailed release notes, see Firebase JavaScript SDK Release Notes."? You might want to test if you have to escape any of those markdown linking characters.
Changesets are better than commits but I think release notes may have more info than changesets.
There was a problem hiding this comment.
Done. Here's an example release with the new release notes: https://github.com/dlarocque/firebase-js-sdk/releases/tag/firebase%405.5.5
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| # Get the newest release tag for the firebase package (e.g. [email protected]) | ||
| NEWEST_TAG=$(git describe --tags --match "firebase@[0-9]*.[0-9]*.[0-9]*" --abbrev=0) |
There was a problem hiding this comment.
Nice use of --match to solve this problem.
dlarocque
force-pushed
the
dlarocque/github-releases
branch
from
36e3f65
to
52cbd72
Compare
Adds a job to the production release workflow to create a GitHub release.
I tested this on a minimal version (no build or npm publish) of the workflow on a fork. It adds and pushes tags the same way that the
scripts/release/release.tsscript does.Test workflow: https://github.com/dlarocque/firebase-js-sdk/blob/master/.github/workflows/test-release.yml
Resulting release: https://github.com/dlarocque/firebase-js-sdk/releases/tag/firebase%405.5.5
This job assumes that the version packages PR was already merged.