Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc comments #8234

Merged
merged 3 commits into from
May 8, 2024
Merged

Fix doc comments #8234

merged 3 commits into from
May 8, 2024

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented May 8, 2024

Fix docs based on comments in cl/631623581 (internal)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 486e000

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review May 8, 2024 16:40
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 8, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/vertexai-preview

    TypeBase (f688228)Merge (d22a531)Diff
    browser25.1 kB25.2 kB+85 B (+0.3%)
    main25.7 kB25.8 kB+85 B (+0.3%)
    module25.1 kB25.2 kB+85 B (+0.3%)

  • firebase

    TypeBase (f688228)Merge (d22a531)Diff
    firebase-vertexai-preview.js19.2 kB19.3 kB+35 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TDEPjIrheb.html

egilmorez
egilmorez approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Bonus points if Rachel can also approve.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 8, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/vertexai-preview

    • ChatSession

      Size

      TypeBase (f688228)Merge (d22a531)Diff
      size14.4 kB14.4 kB+42 B (+0.3%)
      size-with-ext-deps32.8 kB32.8 kB+42 B (+0.1%)

    • GenerativeModel

      Size

      TypeBase (f688228)Merge (d22a531)Diff
      size16.6 kB16.7 kB+42 B (+0.3%)
      size-with-ext-deps35.0 kB35.1 kB+42 B (+0.1%)

    • getGenerativeModel

      Size

      TypeBase (f688228)Merge (d22a531)Diff
      size16.7 kB16.7 kB+42 B (+0.3%)
      size-with-ext-deps35.1 kB35.2 kB+42 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zLqi8zo3wM.html

rachelsaunders
rachelsaunders approved these changes May 8, 2024
View reviewed changes
docs-devsite/vertexai-preview.md Outdated Show resolved Hide resolved
@hsubox76 hsubox76 merged commit c66445c into ch-vertex-feature May 8, 2024
22 checks passed
@hsubox76 hsubox76 deleted the ch-docs-2 branch May 8, 2024 18:45
@firebase firebase locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachelsaunders rachelsaunders rachelsaunders approved these changes

@DellaBitta DellaBitta DellaBitta approved these changes

@egilmorez egilmorez egilmorez approved these changes

@markarndt markarndt Awaiting requested review from markarndt

@kevinthecheung kevinthecheung Awaiting requested review from kevinthecheung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hsubox76 @google-oss-bot @egilmorez @DellaBitta @rachelsaunders