Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VertexAI] fix test #8228

Merged
merged 1 commit into from
May 7, 2024
Merged

[VertexAI] fix test #8228

merged 1 commit into from
May 7, 2024

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented May 7, 2024

Missed a failing test on: #8216

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: 29e02a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review May 7, 2024 18:24
@hsubox76 hsubox76 requested a review from a team as a code owner May 7, 2024 18:24
dlarocque
dlarocque approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@dlarocque dlarocque left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad! I need to be more thorough in validating my PRs before I merge.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/analytics

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?21.8 kB? (?)
    esm5?26.9 kB? (?)
    main?28.4 kB? (?)
    module?21.8 kB? (?)

  • @firebase/analytics-compat

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?2.57 kB? (?)
    esm5?2.80 kB? (?)
    main?3.24 kB? (?)
    module?2.57 kB? (?)

  • @firebase/api-documenter

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    main?3.95 kB? (?)

  • @firebase/app

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?18.1 kB? (?)
    esm5?23.7 kB? (?)
    main?24.8 kB? (?)
    module?18.1 kB? (?)

  • @firebase/app-check

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?26.3 kB? (?)
    esm5?31.6 kB? (?)
    main?32.8 kB? (?)
    module?26.3 kB? (?)

  • @firebase/app-check-compat

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?2.27 kB? (?)
    esm5?2.48 kB? (?)
    main?2.94 kB? (?)
    module?2.27 kB? (?)

  • @firebase/app-compat

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?5.28 kB? (?)
    esm5?6.13 kB? (?)
    lite?4.06 kB? (?)
    main?6.73 kB? (?)
    module?5.28 kB? (?)

  • @firebase/auth

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?182 kB? (?)
    cordova?210 kB? (?)
    esm5?236 kB? (?)
    main?179 kB? (?)
    module?182 kB? (?)
    react-native?199 kB? (?)

  • @firebase/auth-compat

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?20.2 kB? (?)
    esm5?27.1 kB? (?)
    main?29.5 kB? (?)
    module?20.2 kB? (?)

  • @firebase/auth/cordova

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?210 kB? (?)
    module?210 kB? (?)

  • @firebase/auth/internal

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?193 kB? (?)
    esm5?250 kB? (?)
    main?215 kB? (?)
    module?193 kB? (?)

  • @firebase/auth/web-extension

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?137 kB? (?)
    main?152 kB? (?)
    module?137 kB? (?)

  • @firebase/component

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?6.54 kB? (?)
    esm5?8.70 kB? (?)
    main?9.08 kB? (?)
    module?6.54 kB? (?)

  • @firebase/database

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?249 kB? (?)
    esm5?277 kB? (?)
    main?282 kB? (?)
    module?249 kB? (?)

  • @firebase/database-compat

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?18.3 kB? (?)
    esm5?21.4 kB? (?)
    main?22.2 kB? (?)
    module?18.3 kB? (?)

  • @firebase/database-compat/standalone

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    main?372 kB? (?)

  • @firebase/firestore

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?377 kB? (?)
    esm5?362 kB? (?)
    main?580 kB? (?)
    module?377 kB? (?)
    react-native?377 kB? (?)

  • @firebase/firestore-compat

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?20.6 kB? (?)
    esm5?27.7 kB? (?)
    main?21.0 kB? (?)
    module?20.6 kB? (?)
    react-native?20.6 kB? (?)

  • @firebase/firestore-lite

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?109 kB? (?)
    esm5?106 kB? (?)
    main?150 kB? (?)
    module?109 kB? (?)
    react-native?109 kB? (?)

  • @firebase/functions

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?9.72 kB? (?)
    esm5?12.1 kB? (?)
    main?12.7 kB? (?)
    module?9.72 kB? (?)

  • @firebase/functions-compat

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?1.79 kB? (?)
    esm5?1.98 kB? (?)
    main?2.34 kB? (?)
    module?1.79 kB? (?)

  • @firebase/installations

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?17.8 kB? (?)
    esm5?23.1 kB? (?)
    main?23.9 kB? (?)
    module?17.8 kB? (?)

  • @firebase/installations-compat

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?944 B? (?)
    esm5?1.16 kB? (?)
    main?1.48 kB? (?)
    module?944 B? (?)

  • @firebase/logger

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    esm5?4.75 kB? (?)
    main?5.41 kB? (?)
    module?3.25 kB? (?)

  • @firebase/messaging

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?21.3 kB? (?)
    esm5?26.8 kB? (?)
    main?27.4 kB? (?)
    module?21.3 kB? (?)

  • @firebase/messaging-compat

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?2.08 kB? (?)
    esm5?2.51 kB? (?)
    main?2.90 kB? (?)
    module?2.08 kB? (?)

  • @firebase/messaging-sw

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    main?30.4 kB? (?)
    module?23.6 kB? (?)

  • @firebase/performance

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?29.1 kB? (?)
    esm5?31.0 kB? (?)
    main?31.4 kB? (?)
    module?29.1 kB? (?)

  • @firebase/performance-compat

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?1.10 kB? (?)
    esm5?1.37 kB? (?)
    main?1.69 kB? (?)
    module?1.10 kB? (?)

  • @firebase/remote-config

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?19.2 kB? (?)
    esm5?24.1 kB? (?)
    main?25.3 kB? (?)
    module?19.2 kB? (?)

  • @firebase/remote-config-compat

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?1.85 kB? (?)
    esm5?2.76 kB? (?)
    main?3.09 kB? (?)
    module?1.85 kB? (?)

  • @firebase/rules-unit-testing

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    main?17.8 kB? (?)

  • @firebase/storage

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?57.8 kB? (?)
    esm5?64.3 kB? (?)
    main?59.4 kB? (?)
    module?57.8 kB? (?)

  • @firebase/storage-compat

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?5.67 kB? (?)
    esm5?8.41 kB? (?)
    main?8.82 kB? (?)
    module?5.67 kB? (?)

  • @firebase/util

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?23.1 kB? (?)
    esm5?24.7 kB? (?)
    main?30.5 kB? (?)
    module?23.1 kB? (?)

  • @firebase/vertexai-preview

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?25.1 kB? (?)
    main?25.7 kB? (?)
    module?25.1 kB? (?)

  • @firebase/webchannel-wrapper

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    main?38 B? (?)

  • @firebase/webchannel-wrapper/bloom-blob

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?11.1 kB? (?)
    esm5?11.1 kB? (?)
    main?11.1 kB? (?)
    module?11.1 kB? (?)

  • @firebase/webchannel-wrapper/webchannel-blob

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    browser?44.3 kB? (?)
    esm5?55.6 kB? (?)
    main?44.3 kB? (?)
    module?44.3 kB? (?)

  • bundle

    46 size changes

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    analytics (logEvent)?44.5 kB? (?)
    app-check (CustomProvider)?37.3 kB? (?)
    app-check (ReCaptchaEnterpriseProvider)?39.9 kB? (?)
    app-check (ReCaptchaV3Provider)?39.8 kB? (?)
    auth (Anonymous)?76.0 kB? (?)
    auth (EmailAndPassword)?84.3 kB? (?)
    auth (GoogleFBTwitterGitHubPopup)?103 kB? (?)
    auth (GooglePopup)?100 kB? (?)
    auth (GoogleRedirect)?101 kB? (?)
    auth (Phone)?86.7 kB? (?)
    database (Append to a list of data)?149 kB? (?)
    database (Filtering data)?148 kB? (?)
    database (Listen for child events)?164 kB? (?)
    database (Listen for value events + Detach listeners)?164 kB? (?)
    database (Listen for value events)?164 kB? (?)
    database (Read data once)?164 kB? (?)
    database (Save data as transactions)?166 kB? (?)
    database (Sort data)?150 kB? (?)
    database (Write data)?148 kB? (?)
    firestore (CSI Auto Indexing Disable and Delete)?270 kB? (?)
    firestore (CSI Auto Indexing Enable)?270 kB? (?)
    firestore (Persistence)?305 kB? (?)
    firestore (Query Cursors)?242 kB? (?)
    firestore (Query)?240 kB? (?)
    firestore (Read data once)?228 kB? (?)
    firestore (Read Write w Persistence)?325 kB? (?)
    firestore (Realtime updates)?230 kB? (?)
    firestore (Transaction)?207 kB? (?)
    firestore (Write data)?207 kB? (?)
    firestore-lite (Query Cursors)?89.8 kB? (?)
    firestore-lite (Query)?85.9 kB? (?)
    firestore-lite (Read data once)?62.1 kB? (?)
    firestore-lite (Transaction)?87.1 kB? (?)
    firestore-lite (Write data)?71.7 kB? (?)
    functions (call)?31.9 kB? (?)
    messaging (send + receive)?46.9 kB? (?)
    performance (trace)?51.7 kB? (?)
    remote-config (getAndFetch)?46.2 kB? (?)
    storage (getBytes)?42.0 kB? (?)
    storage (getDownloadURL)?44.1 kB? (?)
    storage (getMetadata)?43.5 kB? (?)
    storage (list + listAll)?43.0 kB? (?)
    storage (updateMetadata)?43.8 kB? (?)
    storage (uploadBytes)?48.7 kB? (?)
    storage (uploadBytesResumable)?58.6 kB? (?)
    storage (uploadString)?48.9 kB? (?)

  • firebase

    32 size changes

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    firebase-analytics-compat.js?26.5 kB? (?)
    firebase-analytics.js?29.7 kB? (?)
    firebase-app-check-compat.js?23.4 kB? (?)
    firebase-app-check.js?25.0 kB? (?)
    firebase-app-compat.js?31.4 kB? (?)
    firebase-app.js?102 kB? (?)
    firebase-auth-compat.js?140 kB? (?)
    firebase-auth-cordova.js?177 kB? (?)
    firebase-auth-web-extension.js?117 kB? (?)
    firebase-auth.js?151 kB? (?)
    firebase-compat.js?788 kB? (?)
    firebase-database-compat.js?166 kB? (?)
    firebase-database.js?186 kB? (?)
    firebase-firestore-compat.js?343 kB? (?)
    firebase-firestore-lite.js?117 kB? (?)
    firebase-firestore.js?438 kB? (?)
    firebase-functions-compat.js?8.19 kB? (?)
    firebase-functions.js?11.9 kB? (?)
    firebase-installations-compat.js?13.3 kB? (?)
    firebase-installations.js?15.1 kB? (?)
    firebase-messaging-compat.js?38.4 kB? (?)
    firebase-messaging-sw.js?30.2 kB? (?)
    firebase-messaging.js?28.7 kB? (?)
    firebase-performance-compat.js?30.8 kB? (?)
    firebase-performance-standalone-compat.es2017.js?93.3 kB? (?)
    firebase-performance-standalone-compat.js?70.4 kB? (?)
    firebase-performance.js?35.0 kB? (?)
    firebase-remote-config-compat.js?27.3 kB? (?)
    firebase-remote-config.js?29.6 kB? (?)
    firebase-storage-compat.js?40.3 kB? (?)
    firebase-storage.js?46.2 kB? (?)
    firebase-vertexai-preview.js?19.2 kB? (?)

  • functions

    TypeBase (dc2efe7)Merge (58b6a92)Diff
    main?46 B? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4WRr12EjbQ.html

@hsubox76 hsubox76 merged commit 4c83b34 into ch-vertex-feature May 7, 2024
39 of 41 checks passed
@hsubox76 hsubox76 deleted the ch-vertex-filedata branch May 7, 2024 18:44
@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

This report is too large (1,924,681 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gY41Z2JgMm.html

@firebase firebase locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dlarocque dlarocque dlarocque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @dlarocque