Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional Vertex types #8131

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Add additional Vertex types #8131

merged 2 commits into from
Apr 8, 2024

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Apr 5, 2024 •
edited
Loading

After doing an audit, added a number of Vertex types that were missing in the JS SDK.

See https://docs.google.com/document/d/1E-Kw5NC5iwtAA4_D9O7eNM4DpT8OZjwY8YwKUrDSNSI/edit?resourcekey=0-agpRR_nc-s3n4cCy4tBkOQ&tab=t.0 (internal)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 07c02a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review April 5, 2024 23:20
@hsubox76 hsubox76 requested a review from a team as a code owner April 5, 2024 23:20
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 5, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (acef5e3)Merge (b792f25)Diff
    browser22.3 kB23.0 kB+666 B (+3.0%)
    main22.9 kB23.6 kB+691 B (+3.0%)
    module22.3 kB23.0 kB+666 B (+3.0%)

  • firebase

    TypeBase (acef5e3)Merge (b792f25)Diff
    firebase-vertexai.js17.3 kB17.7 kB+443 B (+2.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Gl6rGwittr.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 5, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • BlockReason

      Size

      TypeBase (acef5e3)Merge (b792f25)Diff
      size2.85 kB3.29 kB+440 B (+15.4%)
      size-with-ext-deps20.5 kB21.0 kB+446 B (+2.2%)

      Dependency

      TypeBase (acef5e3)Merge (b792f25)Diff
      variables

      12 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockThreshold
HarmCategory
HarmProbability
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      + HarmBlockMethod
+ HarmSeverity

    • ChatSession

      Size

      TypeBase (acef5e3)Merge (b792f25)Diff
      size13.1 kB13.5 kB+444 B (+3.4%)
      size-with-ext-deps31.5 kB31.9 kB+446 B (+1.4%)

      Dependency

      TypeBase (acef5e3)Merge (b792f25)Diff
      variables

      24 dependencies

      BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
ERRORS
ERROR_FACTORY
FinishReason
FunctionDeclarationSchemaType
HarmBlockThreshold
HarmCategory
HarmProbability
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

      26 dependencies

      BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
ERRORS
ERROR_FACTORY
FinishReason
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

      + HarmBlockMethod
+ HarmSeverity

    • FinishReason

      Size

      TypeBase (acef5e3)Merge (b792f25)Diff
      size2.85 kB3.29 kB+440 B (+15.4%)
      size-with-ext-deps20.5 kB21.0 kB+446 B (+2.2%)

      Dependency

      TypeBase (acef5e3)Merge (b792f25)Diff
      variables

      12 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockThreshold
HarmCategory
HarmProbability
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      + HarmBlockMethod
+ HarmSeverity

    • FunctionDeclarationSchemaType

      Size

      TypeBase (acef5e3)Merge (b792f25)Diff
      size2.87 kB3.31 kB+440 B (+15.3%)
      size-with-ext-deps20.5 kB21.0 kB+446 B (+2.2%)

      Dependency

      TypeBase (acef5e3)Merge (b792f25)Diff
      variables

      12 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockThreshold
HarmCategory
HarmProbability
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      + HarmBlockMethod
+ HarmSeverity

    • GenerativeModel

      Size

      TypeBase (acef5e3)Merge (b792f25)Diff
      size14.7 kB15.1 kB+445 B (+3.0%)
      size-with-ext-deps33.1 kB33.5 kB+446 B (+1.3%)

      Dependency

      TypeBase (acef5e3)Merge (b792f25)Diff
      variables

      24 dependencies

      BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
ERRORS
ERROR_FACTORY
FinishReason
FunctionDeclarationSchemaType
HarmBlockThreshold
HarmCategory
HarmProbability
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

      26 dependencies

      BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
ERRORS
ERROR_FACTORY
FinishReason
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

      + HarmBlockMethod
+ HarmSeverity

    • HarmBlockMethod

      Size

      TypeBase (acef5e3)Merge (b792f25)Diff
      size?3.29 kB? (?)
      size-with-ext-deps?21.0 kB? (?)

      Dependency

      TypeBase (acef5e3)Merge (b792f25)Diff
      functions?

      registerVertex

      		?
      classes?

      VertexAIService

      		?
      variables?

      14 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      		?
      enums??

      External Dependency

      ModuleBase (acef5e3)Merge (b792f25)Diff
      @firebase/app?

      _registerComponent
registerVersion

      		?
      @firebase/component?

      Component

      		?
      @firebase/util?

      ErrorFactory

      		?

    • HarmBlockThreshold

      Size

      TypeBase (acef5e3)Merge (b792f25)Diff
      size2.86 kB3.30 kB+440 B (+15.4%)
      size-with-ext-deps20.5 kB21.0 kB+446 B (+2.2%)

      Dependency

      TypeBase (acef5e3)Merge (b792f25)Diff
      variables

      12 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockThreshold
HarmCategory
HarmProbability
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      + HarmBlockMethod
+ HarmSeverity

    • HarmCategory

      Size

      TypeBase (acef5e3)Merge (b792f25)Diff
      size2.85 kB3.29 kB+440 B (+15.4%)
      size-with-ext-deps20.5 kB21.0 kB+446 B (+2.2%)

      Dependency

      TypeBase (acef5e3)Merge (b792f25)Diff
      variables

      12 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockThreshold
HarmCategory
HarmProbability
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      + HarmBlockMethod
+ HarmSeverity

    • HarmProbability

      Size

      TypeBase (acef5e3)Merge (b792f25)Diff
      size2.85 kB3.29 kB+440 B (+15.4%)
      size-with-ext-deps20.5 kB21.0 kB+446 B (+2.2%)

      Dependency

      TypeBase (acef5e3)Merge (b792f25)Diff
      variables

      12 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockThreshold
HarmCategory
HarmProbability
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      + HarmBlockMethod
+ HarmSeverity

    • HarmSeverity

      Size

      TypeBase (acef5e3)Merge (b792f25)Diff
      size?3.29 kB? (?)
      size-with-ext-deps?21.0 kB? (?)

      Dependency

      TypeBase (acef5e3)Merge (b792f25)Diff
      functions?

      registerVertex

      		?
      classes?

      VertexAIService

      		?
      variables?

      14 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      		?
      enums??

      External Dependency

      ModuleBase (acef5e3)Merge (b792f25)Diff
      @firebase/app?

      _registerComponent
registerVersion

      		?
      @firebase/component?

      Component

      		?
      @firebase/util?

      ErrorFactory

      		?

    • POSSIBLE_ROLES

      Size

      TypeBase (acef5e3)Merge (b792f25)Diff
      size2.89 kB3.33 kB+440 B (+15.2%)
      size-with-ext-deps20.6 kB21.0 kB+446 B (+2.2%)

      Dependency

      TypeBase (acef5e3)Merge (b792f25)Diff
      variables

      13 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockThreshold
HarmCategory
HarmProbability
POSSIBLE_ROLES
Task
VERTEX_TYPE
name
version

      15 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
POSSIBLE_ROLES
Task
VERTEX_TYPE
name
version

      + HarmBlockMethod
+ HarmSeverity

    • getGenerativeModel

      Size

      TypeBase (acef5e3)Merge (b792f25)Diff
      size14.7 kB15.2 kB+445 B (+3.0%)
      size-with-ext-deps33.1 kB33.6 kB+446 B (+1.3%)

      Dependency

      TypeBase (acef5e3)Merge (b792f25)Diff
      variables

      24 dependencies

      BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
ERRORS
ERROR_FACTORY
FinishReason
FunctionDeclarationSchemaType
HarmBlockThreshold
HarmCategory
HarmProbability
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

      26 dependencies

      BlockReason
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_LOCATION
ERRORS
ERROR_FACTORY
FinishReason
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
VERTEX_TYPE
badFinishReasons
name
responseLineRE
version

      + HarmBlockMethod
+ HarmSeverity

    • getVertexAI

      Size

      TypeBase (acef5e3)Merge (b792f25)Diff
      size2.98 kB3.42 kB+440 B (+14.8%)
      size-with-ext-deps28.0 kB28.4 kB+446 B (+1.6%)

      Dependency

      TypeBase (acef5e3)Merge (b792f25)Diff
      variables

      12 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockThreshold
HarmCategory
HarmProbability
Task
VERTEX_TYPE
name
version

      14 dependencies

      BlockReason
DEFAULT_LOCATION
ERRORS
FinishReason
FunctionDeclarationSchemaType
HarmBlockMethod
HarmBlockThreshold
HarmCategory
HarmProbability
HarmSeverity
Task
VERTEX_TYPE
name
version

      + HarmBlockMethod
+ HarmSeverity

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/u4oOTFfBYM.html

@hsubox76 hsubox76 changed the title Add totalBillableCharacters Add additional Vertex types Apr 8, 2024
@hsubox76 hsubox76 requested a review from DellaBitta April 8, 2024 19:05
@hsubox76 hsubox76 merged commit f25ccbb into ch-vertex-feature Apr 8, 2024
37 of 41 checks passed
@hsubox76 hsubox76 deleted the ch-vertex-billable branch April 8, 2024 20:49
@firebase firebase locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @DellaBitta