Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size report for Firestore client-side indexing #7904

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

dconeybe
Copy link
Contributor

Add two new size reports for Firestore: "CSI Auto Indexing Enable" and "CSI Auto Indexing Disable and Delete". These calculate how much client-side indexing contributes to the bundle size. These numbers will help prioritize the work to make the client-side indexing code tree-shakeable (#7902).

image

@dconeybe dconeybe self-assigned this Dec 24, 2023
Copy link

changeset-bot bot commented Dec 24, 2023

⚠️ No Changeset found

Latest commit: b075546

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • bundle

    TypeBase (537d399)Merge (1731958)Diff
    firestore (CSI Auto Indexing Disable and Delete)?268 kB? (?)
    firestore (CSI Auto Indexing Enable)?268 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MUKqfxn5Gl.html

@dconeybe dconeybe marked this pull request as ready for review December 24, 2023 06:21
@dconeybe dconeybe requested a review from a team as a code owner December 24, 2023 06:21
@dconeybe dconeybe merged commit 7f78362 into master Jan 4, 2024
36 checks passed
@dconeybe dconeybe deleted the dconeybe/SizeReportForClientSideIndexing branch January 4, 2024 18:28
@firebase firebase deleted a comment Jan 4, 2024
@firebase firebase locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants