Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Check] Install catch handler for promise in Deferred. #7822

Merged
merged 2 commits into from
Nov 29, 2023
Merged

[App Check] Install catch handler for promise in Deferred. #7822

merged 2 commits into from
Nov 29, 2023

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Nov 28, 2023 •
edited
Loading

Discussion

Install catch handlers for promises in the Derferred object used by in AppCheck. There were some cases where the promise was cancelled and this bubbled up error messages to our clients' applications despite this being expected behavior.

This change is to alleviate the logging reported in issue #7805.

Testing

CI.

API Changes

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 56a6b25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/app-check Patch
@firebase/app-check-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 28, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app-check

    TypeBase (e8ff8b8)Merge (16083a6)Diff
    browser26.2 kB26.3 kB+74 B (+0.3%)
    esm531.5 kB31.6 kB+90 B (+0.3%)
    main32.7 kB32.8 kB+90 B (+0.3%)
    module26.2 kB26.3 kB+74 B (+0.3%)

  • bundle

    TypeBase (e8ff8b8)Merge (16083a6)Diff
    app-check (CustomProvider)36.8 kB36.9 kB+72 B (+0.2%)
    app-check (ReCaptchaEnterpriseProvider)39.3 kB39.4 kB+72 B (+0.2%)
    app-check (ReCaptchaV3Provider)39.3 kB39.4 kB+72 B (+0.2%)

  • firebase

    TypeBase (e8ff8b8)Merge (16083a6)Diff
    firebase-app-check-compat.js23.3 kB23.4 kB+68 B (+0.3%)
    firebase-app-check.js25.0 kB25.0 kB+72 B (+0.3%)
    firebase-compat.js779 kB779 kB+68 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lOEZltQ9k3.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 28, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/app-check

    • CustomProvider

      Size

      TypeBase (e8ff8b8)Merge (16083a6)Diff
      size7.65 kB7.72 kB+72 B (+0.9%)
      size-with-ext-deps25.6 kB25.7 kB+72 B (+0.3%)

    • ReCaptchaEnterpriseProvider

      Size

      TypeBase (e8ff8b8)Merge (16083a6)Diff
      size11.3 kB11.4 kB+72 B (+0.6%)
      size-with-ext-deps29.2 kB29.2 kB+72 B (+0.2%)

    • ReCaptchaV3Provider

      Size

      TypeBase (e8ff8b8)Merge (16083a6)Diff
      size11.3 kB11.4 kB+72 B (+0.6%)
      size-with-ext-deps29.1 kB29.2 kB+72 B (+0.2%)

    • getLimitedUseToken

      Size

      TypeBase (e8ff8b8)Merge (16083a6)Diff
      size7.22 kB7.29 kB+72 B (+1.0%)
      size-with-ext-deps24.7 kB24.8 kB+72 B (+0.3%)

    • getToken

      Size

      TypeBase (e8ff8b8)Merge (16083a6)Diff
      size7.28 kB7.35 kB+72 B (+1.0%)
      size-with-ext-deps24.8 kB24.9 kB+72 B (+0.3%)

    • initializeAppCheck

      Size

      TypeBase (e8ff8b8)Merge (16083a6)Diff
      size11.1 kB11.2 kB+72 B (+0.6%)
      size-with-ext-deps35.8 kB35.9 kB+72 B (+0.2%)

    • onTokenChanged

      Size

      TypeBase (e8ff8b8)Merge (16083a6)Diff
      size7.37 kB7.44 kB+72 B (+1.0%)
      size-with-ext-deps24.9 kB25.0 kB+72 B (+0.3%)

    • setTokenAutoRefreshEnabled

      Size

      TypeBase (e8ff8b8)Merge (16083a6)Diff
      size7.37 kB7.44 kB+72 B (+1.0%)
      size-with-ext-deps24.9 kB24.9 kB+72 B (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/90XGSAgvhV.html

@DellaBitta DellaBitta marked this pull request as ready for review November 28, 2023 23:17
@DellaBitta DellaBitta requested review from a team and hsubox76 as code owners November 28, 2023 23:17
@DellaBitta DellaBitta changed the title install catch handler for promise in Deferred. [App Check] Install catch handler for promise in Deferred. Nov 28, 2023
@DellaBitta DellaBitta merged commit 1d32137 into master Nov 29, 2023
33 checks passed
@DellaBitta DellaBitta deleted the ddb-appcheck-promise-catch branch November 29, 2023 19:26
@google-oss-bot google-oss-bot mentioned this pull request Dec 4, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DellaBitta @google-oss-bot @hsubox76