Decouple code reformat from boom filter

[milaGGL]

Decoupling some code refactor/relocating from the actual implementation of bloom filter.

[changeset-bot]

⚠️ No Changeset found

Latest commit: d6c5f66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[google-oss-bot]

Size Report ¹

Affected Products

• @firebase/firestore

  Type	Base (27b5e7d)	Merge (8d65c29)	Diff
  browser	273 kB	273 kB	+271 B (+0.1%)
  esm5	339 kB	340 kB	+370 B (+0.1%)
  main	546 kB	546 kB	+80 B (+0.0%)
  module	273 kB	273 kB	+271 B (+0.1%)
  react-native	273 kB	273 kB	+286 B (+0.1%)

• @firebase/firestore-lite

  Type	Base (27b5e7d)	Merge (8d65c29)	Diff
  browser	86.2 kB	86.4 kB	+271 B (+0.3%)
  esm5	104 kB	104 kB	+366 B (+0.4%)
  main	147 kB	147 kB	+80 B (+0.1%)
  module	86.2 kB	86.4 kB	+271 B (+0.3%)
  react-native	86.4 kB	86.7 kB	+288 B (+0.3%)

• @firebase/util

  Type	Base (27b5e7d)	Merge (8d65c29)	Diff
  browser	22.9 kB	23.1 kB	+159 B (+0.7%)
  esm5	24.4 kB	24.7 kB	+315 B (+1.3%)
  main	30.0 kB	30.4 kB	+443 B (+1.5%)
  module	22.9 kB	23.1 kB	+159 B (+0.7%)

• bundle

  43 size changes

  Type	Base (27b5e7d)	Merge (8d65c29)	Diff
  analytics (logEvent)	43.0 kB	43.1 kB	+93 B (+0.2%)
  app-check (CustomProvider)	36.1 kB	36.2 kB	+93 B (+0.3%)
  app-check (ReCaptchaEnterpriseProvider)	38.4 kB	38.5 kB	+95 B (+0.2%)
  app-check (ReCaptchaV3Provider)	38.4 kB	38.5 kB	+95 B (+0.2%)
  auth (Anonymous)	67.4 kB	67.5 kB	+95 B (+0.1%)
  auth (EmailAndPassword)	71.5 kB	71.6 kB	+95 B (+0.1%)
  auth (GoogleFBTwitterGitHubPopup)	93.9 kB	94.0 kB	+94 B (+0.1%)
  auth (GooglePopup)	91.1 kB	91.2 kB	+95 B (+0.1%)
  auth (GoogleRedirect)	91.4 kB	91.5 kB	+95 B (+0.1%)
  auth (Phone)	77.6 kB	77.7 kB	+95 B (+0.1%)
  database (Append to a list of data)	148 kB	148 kB	+93 B (+0.1%)
  database (Filtering data)	147 kB	147 kB	+93 B (+0.1%)
  database (Listen for child events)	163 kB	164 kB	+93 B (+0.1%)
  database (Listen for value events + Detach listeners)	163 kB	164 kB	+93 B (+0.1%)
  database (Listen for value events)	163 kB	163 kB	+93 B (+0.1%)
  database (Read data once)	163 kB	163 kB	+93 B (+0.1%)
  database (Save data as transactions)	165 kB	165 kB	+93 B (+0.1%)
  database (Sort data)	149 kB	149 kB	+93 B (+0.1%)
  database (Write data)	147 kB	147 kB	+93 B (+0.1%)
  firestore (Persistence)	281 kB	281 kB	+364 B (+0.1%)
  firestore (Query Cursors)	220 kB	220 kB	+364 B (+0.2%)
  firestore (Query)	218 kB	218 kB	+364 B (+0.2%)
  firestore (Read data once)	205 kB	205 kB	+364 B (+0.2%)
  firestore (Realtime updates)	207 kB	207 kB	+364 B (+0.2%)
  firestore (Transaction)	188 kB	188 kB	+364 B (+0.2%)
  firestore (Write data)	188 kB	188 kB	+364 B (+0.2%)
  firestore-lite (Query Cursors)	81.3 kB	81.6 kB	+364 B (+0.4%)
  firestore-lite (Query)	77.4 kB	77.8 kB	+364 B (+0.5%)
  firestore-lite (Read data once)	59.4 kB	59.7 kB	+364 B (+0.6%)
  firestore-lite (Transaction)	84.0 kB	84.4 kB	+364 B (+0.4%)
  firestore-lite (Write data)	68.9 kB	69.3 kB	+364 B (+0.5%)
  functions (call)	30.9 kB	31.0 kB	+100 B (+0.3%)
  messaging (send + receive)	46.4 kB	46.5 kB	+95 B (+0.2%)
  performance (trace)	50.8 kB	50.9 kB	+95 B (+0.2%)
  remote-config (getAndFetch)	45.4 kB	45.4 kB	+93 B (+0.2%)
  storage (getBytes)	41.1 kB	41.2 kB	+93 B (+0.2%)
  storage (getDownloadURL)	43.2 kB	43.3 kB	+93 B (+0.2%)
  storage (getMetadata)	42.7 kB	42.8 kB	+93 B (+0.2%)
  storage (list + listAll)	42.1 kB	42.2 kB	+93 B (+0.2%)
  storage (updateMetadata)	42.9 kB	43.0 kB	+93 B (+0.2%)
  storage (uploadBytes)	48.0 kB	48.1 kB	+93 B (+0.2%)
  storage (uploadBytesResumable)	58.0 kB	58.1 kB	+93 B (+0.2%)
  storage (uploadString)	48.2 kB	48.3 kB	+93 B (+0.2%)

• firebase

  19 size changes

  Type	Base (27b5e7d)	Merge (8d65c29)	Diff
  firebase-app-check-compat.js	22.6 kB	22.7 kB	+101 B (+0.4%)
  firebase-app-check.js	21.4 kB	21.5 kB	+104 B (+0.5%)
  firebase-app-compat.js	28.8 kB	28.9 kB	+99 B (+0.3%)
  firebase-app.js	92.8 kB	93.1 kB	+243 B (+0.3%)
  firebase-auth-compat.js	126 kB	126 kB	+101 B (+0.1%)
  firebase-auth-cordova.js	138 kB	138 kB	+96 B (+0.1%)
  firebase-auth-react-native.js	150 kB	150 kB	+126 B (+0.1%)
  firebase-auth.js	117 kB	117 kB	+101 B (+0.1%)
  firebase-compat.js	747 kB	747 kB	+373 B (+0.0%)
  firebase-database-compat.js	166 kB	166 kB	+105 B (+0.1%)
  firebase-database.js	154 kB	154 kB	+100 B (+0.1%)
  firebase-firestore-compat.js	321 kB	321 kB	+371 B (+0.1%)
  firebase-firestore-lite.js	92.9 kB	93.2 kB	+370 B (+0.4%)
  firebase-firestore.js	321 kB	322 kB	+373 B (+0.1%)
  firebase-functions.js	10.9 kB	11.0 kB	+91 B (+0.8%)
  firebase-performance-standalone-compat.es2017.js	89.9 kB	90.0 kB	+106 B (+0.1%)
  firebase-performance-standalone-compat.js	67.0 kB	67.2 kB	+140 B (+0.2%)
  firebase-storage-compat.js	41.2 kB	41.3 kB	+101 B (+0.2%)
  firebase-storage.js	40.2 kB	40.3 kB	+99 B (+0.2%)

Test Logs

• Base (27b5e7d): https://github.com/firebase/firebase-js-sdk/actions/runs/4056860856
• Merge (8d65c29): https://github.com/firebase/firebase-js-sdk/actions/runs/4078016522

1. https://storage.googleapis.com/firebase-sdk-metric-reports/p94lPOl69y.html

[google-oss-bot]

Size Analysis Report ¹

This report is too large (736,029 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

• Base (27b5e7d): https://github.com/firebase/firebase-js-sdk/actions/runs/4056860856
• Merge (8d65c29): https://github.com/firebase/firebase-js-sdk/actions/runs/4078016522

1. https://storage.googleapis.com/firebase-sdk-metric-reports/uxLpie9mZd.html

[milaGGL]

Closing to de-prioritize. Will create new PRs later with code break ups.