Skip to content

Make some doc comment changes #6229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2022
Merged

Make some doc comment changes #6229

merged 1 commit into from
May 5, 2022

Conversation

@hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented May 5, 2022

Update some comment text for reference docs.

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2022

⚠️ No Changeset found

Latest commit: 24c9576

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 5, 2022

Size Report 1

Affected Products

  • firebase

    TypeBase (6e8983c)Merge (05e34d9)Diff
    firebase-auth-cordova.js471 kB471 kB+2 B (+0.0%)
    firebase-auth-react-native.js494 kB494 kB+2 B (+0.0%)
    firebase-auth.js416 kB416 kB+2 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/v5qbVXrZcL.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 5, 2022

Size Analysis Report 1

Affected Products

No changes between base commit (6e8983c) and merge commit (05e34d9).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Cdl7o3P1TI.html

@hsubox76 hsubox76 merged commit a6b0d2c into sam-gc/on-abort May 5, 2022
@hsubox76 hsubox76 deleted the ch-auth-doc-changes branch May 5, 2022 18:41
sam-gc pushed a commit that referenced this pull request May 5, 2022
@hsubox76 @sam-gc
Make some doc comment changes (#6229)
955f2dc
sam-gc added a commit that referenced this pull request May 5, 2022
@sam-gc @yuchenshi
@jamesdaniels @hsubox76
[Auth] Add onAbort and refactor middleware (#6178)
d29a4fa 
* Add onAbort and refactor middleware

* Update packages/auth/src/core/auth/middleware.test.ts

Co-authored-by: Yuchen Shi <[email protected]>

* Add beforeAuthStateChanged fn export (#6222)

* Make some doc comment changes (#6229)

Co-authored-by: Yuchen Shi <[email protected]>
Co-authored-by: James Daniels <[email protected]>
Co-authored-by: Christina Holland <[email protected]>
@firebase firebase locked and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sam-gc sam-gc sam-gc approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@lisajian lisajian Awaiting requested review from lisajian

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hsubox76 @google-oss-bot @sam-gc