Drop Node 6 / Replace grpc w/ @grpc/grpc-js #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
avolkovi,
Feiyang1,
hiranya911,
hsubox76,
sam-gc,
scottcrossen and
yuchenshi
as code owners
schmidt-sebastian
force-pushed
the
mrschmidt/grpcjs
branch
2 times, most recently
from
9b4cd43
to
309a105
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/grpcjs
branch
from
309a105
to
e0fb73d
Compare
Binary Size ReportAffected SDKs
Test Logs |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
yuchenshi
approved these changes
Apr 3, 2020
Feiyang1
suggested changes
Apr 6, 2020
packages/testing/package.json
Outdated
| @@ -20,7 +23,7 @@ | |||
| "@firebase/logger": "0.2.1", | |||
| "@firebase/util": "0.2.44", | |||
| "@types/request": "2.48.4", | |||
| "grpc": "1.24.2", | |||
| "firebase": "7.13.1", | |||
There was a problem hiding this comment.
It is redundant. firebase is already a dependency.
Was grpc a redundant dependency anyway regardless of this change?
Feiyang1
reviewed
Apr 6, 2020
| @@ -25,8 +25,7 @@ import { | |||
| import firebase from '@firebase/app'; | |||
| const SDK_VERSION = firebase.SDK_VERSION; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-require-imports | |||
| const grpcVersion = require('@grpc/grpc-js/package.json').version; | |||
| const grpcVersion = import('@grpc/grpc-js/package.json').version; | |||
There was a problem hiding this comment.
You could also use a normal import, then add a plugin in the rollup.config.js.
import { version } from '@grpc/grpc-js/package.json'
There was a problem hiding this comment.
We already use this build setting, but since we don't use rollup for our unit tests, this breaks the unit test.
Feiyang1
approved these changes
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@grpc/grpc-jsgrpc, replaces all usages with@grpc/grpc-js@types/node, which is required to make@grpc/grpc-jscompile. This also addsfinallyto the Promise API, which requires a small code change.Note that there are currently two version of
@grpc/grpc-jsin our repo, which should go away once firebase/firebase-tools#2093 is released.