Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Replace grpc with grpc-js #1783

Closed
max-mapper opened this issue May 14, 2019 · 8 comments · Fixed by #1804
Closed

FR: Replace grpc with grpc-js #1783

max-mapper opened this issue May 14, 2019 · 8 comments · Fixed by #1804

Comments

@max-mapper
Copy link

Hi, I noticed that last week the https://github.com/googleapis/nodejs-firestore package got rid of the grpc node native addon and replaced it with @grpc/grpc-js. I was wondering if this package was planning on upgrading to grpc-js to remove the complexity of dealing with compiled node addons for different platforms like node and electron. I couldn't find any discussion on this in the issue tracker. Thanks!

@mikelehen
Copy link
Contributor

Thanks for bringing this up! Yes, we are intending to upgrade to grpc-js. It seems like this should be a painless switch with no downsides. The main risk is that it's still beta, so we may drag our feet just a little bit in case there are any issues discovered in the near future. But if you're running into a specific issue that you think this would solve, we could look at doing it sooner (or if you felt inclined to make a PR for it, that could also speed things along. 😄).

mikelehen pushed a commit that referenced this issue May 20, 2019
Fixes #1783, reduces package size, and should ease compatibility issues with Electron, etc.
mikelehen pushed a commit that referenced this issue May 21, 2019
Fixes #1783, reduces package size, and should ease compatibility issues with Electron, etc.
@mikelehen
Copy link
Contributor

Unfortunately this had to be reverted (#1813) because it is a breaking change and so must wait until the next time we make a breaking change release to firebase (and increase the major version number). Sorry for the inconvenience!

@mikelehen mikelehen reopened this May 24, 2019
@railerbailer
Copy link

Hello! I would love an update to when this might happen! 😄

@ctavan
Copy link

ctavan commented Oct 25, 2019

Next.js SSR would also benefit from this change: vercel/next.js#7894

@mkonikov
Copy link

Any idea when to expect the next major release?

@var-const
Copy link
Contributor

@mkonikov Historically, we’ve made breaking changes around May, but note that doesn’t mean we’ll do so this year or even that this change will necessarily be in the next breaking change.

@drizzd
Copy link

drizzd commented Mar 8, 2020

This should address Electron's deprecation of non context-aware native modules:

(node:380) Electron: Loading non context-aware native modules in the renderer process is deprecated and will stop working at some point in the future, please see https://github.com/electron/electron/issues/18397 for more information

@schmidt-sebastian
Copy link
Contributor

We are trying this again this week and officially dropping Node 6 support.

#2856

@firebase firebase locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.