Skip to content

Fdl unit tests #9511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldhosembabu merged 6 commits into from
Mar 23, 2022
Merged

Fdl unit tests #9511

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1af6cfe
Adding couple of unit test args
eldhosembabu Mar 23, 2022
8e8f8ef
Merge remote-tracking branch 'refs/remotes/origin/master'
eldhosembabu Mar 23, 2022
c06f321
Adding unit tests to further check custom domain validations.
eldhosembabu Mar 23, 2022
c2904dc
Removing unwanted function
eldhosembabu Mar 23, 2022
68ed475
more tests
eldhosembabu Mar 23, 2022
6448655
Formating
eldhosembabu Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions FirebaseDynamicLinks/Tests/Unit/FIRDynamicLinksTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1615,7 +1615,18 @@ - (void)testValidCustomDomainNames {
NSArray<NSString *> *longFDLURLStrings = @[
@"https://a.firebase.com/mypath/?link=https://abcd&test=1", // Long FDL starting with
// https://a.firebase.com/mypath
@"https://google.com?link=http://abcd", // Long FDL starting with 'https://google.com'
@"https://google.com/?link=http://abcd", // Long FDL starting with 'https://google.com'
@"https://google.com?link=https://somedomain&some=qry", // Long FDL with link param as another
// argument.
@"https://google.com/?link=https://somedomain&some=qry", // Long FDL with link param as another
// argument.
@"https://google.com?some=qry&link=https://somedomain", // Long FDL with link param as second
// argument.
@"https://google.com/?some=qry&link=https://somedomain", // Long FDL with link param as second
// argument
@"https://google.com/?a=b&c=d&link=https://somedomain&y=z", // Long FDL with link param as
// middle argument argument
];
for (NSString *urlString in urlStrings) {
NSURL *url = [NSURL URLWithString:urlString];
Expand All @@ -1638,15 +1649,17 @@ - (void)testInvalidCustomDomainNames {
// https://a.firebase.com/mypath

NSArray<NSString *> *urlStrings = @[
@"google.com", // Valid domain. No scheme.
@"https://google.com", // Valid domain. No path after domainURIPrefix.
@"https://google.com/", // Valid domain. No path after domainURIPrefix.
@"https://google.co.in/mylink", // No matching domainURIPrefix.
@"https://firebase.com/mypath", // No matching domainURIPrefix: Invalid (sub)domain.
@"https://b.firebase.com/mypath", // No matching domainURIPrefix: Invalid subdomain.
@"https://a.firebase.com/mypathabc", // No matching domainURIPrefix: Invalid subdomain.
@"mydomain.com", // https scheme not specified for domainURIPrefix.
@"http://mydomain", // Domain not in plist. No path after domainURIPrefix.
@"google.com", // Valid domain. No scheme.
@"https://google.com", // Valid domain. No path after domainURIPrefix.
@"https://google.com/", // Valid domain. No path after domainURIPrefix.
@"https://google.co.in/mylink", // No matching domainURIPrefix.
@"https://google.com/?some=qry", // Valid domain with no path and link param
@"https://google.com/?some=qry&link=bla", // Valid domain with no path and no valid link param
@"https://firebase.com/mypath", // No matching domainURIPrefix: Invalid (sub)domain.
@"https://b.firebase.com/mypath", // No matching domainURIPrefix: Invalid subdomain.
@"https://a.firebase.com/mypathabc", // No matching domainURIPrefix: Invalid subdomain.
@"mydomain.com", // https scheme not specified for domainURIPrefix.
@"http://mydomain", // Domain not in plist. No path after domainURIPrefix.
@"https://somecustom.com?", @"https://somecustom.com/?",
@"https://somecustom.com?somekey=someval"
];
Expand Down